From 1e33151edcd4a28d5df747cc3360ddd5cf257aab Mon Sep 17 00:00:00 2001
From: Adriano dos Santos Fernandes <adrianosf@gmail.com>
Date: Mon, 21 Oct 2024 22:33:50 -0300
Subject: [PATCH] Fix GCC 14.2 warnings.

---
 examples/udr/UdrCppExample.h                       | 4 ++--
 src/auth/SecureRemotePassword/server/SrpServer.cpp | 2 +-
 src/common/classes/alloc.h                         | 4 +++-
 src/common/classes/stack.h                         | 6 +++---
 4 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/examples/udr/UdrCppExample.h b/examples/udr/UdrCppExample.h
index f2a77ff069..3ed3d779d0 100644
--- a/examples/udr/UdrCppExample.h
+++ b/examples/udr/UdrCppExample.h
@@ -79,7 +79,7 @@ namespace
 	class AutoImpl
 	{
 	public:
-		AutoImpl<T, Clear>(T* aPtr = NULL)
+		AutoImpl(T* aPtr = NULL)
 			: ptr(aPtr)
 		{
 		}
@@ -139,7 +139,7 @@ namespace
 
 	private:
 		// not implemented
-		AutoImpl<T, Clear>(AutoImpl<T, Clear>&);
+		AutoImpl(AutoImpl<T, Clear>&);
 		void operator =(AutoImpl<T, Clear>&);
 
 	private:
diff --git a/src/auth/SecureRemotePassword/server/SrpServer.cpp b/src/auth/SecureRemotePassword/server/SrpServer.cpp
index dbf0ea8eac..3d7abb15f7 100644
--- a/src/auth/SecureRemotePassword/server/SrpServer.cpp
+++ b/src/auth/SecureRemotePassword/server/SrpServer.cpp
@@ -247,7 +247,7 @@ private:
 template <class SHA> class SrpServerImpl final : public SrpServer
 {
 public:
-	explicit SrpServerImpl<SHA>(IPluginConfig* ipc)
+	explicit SrpServerImpl(IPluginConfig* ipc)
 		: SrpServer(ipc)
 	{}
 
diff --git a/src/common/classes/alloc.h b/src/common/classes/alloc.h
index 8ba3a6f1b9..622d95fce3 100644
--- a/src/common/classes/alloc.h
+++ b/src/common/classes/alloc.h
@@ -339,7 +339,7 @@ template <typename SubsystemThreadData, typename SubsystemPool>
 class SubsystemContextPoolHolder : public ContextPoolHolder
 {
 public:
-	SubsystemContextPoolHolder <SubsystemThreadData, SubsystemPool>
+	SubsystemContextPoolHolder
 	(
 		SubsystemThreadData* subThreadData,
 		SubsystemPool* newPool
@@ -350,10 +350,12 @@ public:
 	{
 		savedThreadData->setDefaultPool(newPool);
 	}
+
 	~SubsystemContextPoolHolder()
 	{
 		savedThreadData->setDefaultPool(savedPool);
 	}
+
 private:
 	SubsystemThreadData* savedThreadData;
 	SubsystemPool* savedPool;
diff --git a/src/common/classes/stack.h b/src/common/classes/stack.h
index 3d9989a7c4..4dcc0eb962 100644
--- a/src/common/classes/stack.h
+++ b/src/common/classes/stack.h
@@ -36,7 +36,7 @@ namespace Firebird {
 		class Stack : public AutoStorage
 	{
 	private:
-		Stack<Object, Capacity>(Stack<Object, Capacity>&);	// not implemented
+		Stack(Stack<Object, Capacity>&);	// not implemented
 
 		class Entry : public Vector<Object, Capacity>
 		{
@@ -117,11 +117,11 @@ namespace Firebird {
 		Entry* stk_cache;
 
 	public:
-		explicit Stack<Object, Capacity>(MemoryPool& p)
+		explicit Stack(MemoryPool& p)
 			: AutoStorage(p), stk(0), stk_cache(0)
 		{ }
 
-		Stack<Object, Capacity>() : AutoStorage(), stk(0), stk_cache(0) { }
+		Stack() : AutoStorage(), stk(0), stk_cache(0) { }
 
 		~Stack()
 		{