firebird/firebird-mirror
firebird/firebird-mirror
8
0
Fork 1
mirror of https://github.com/FirebirdSQL/firebird.git synced 2025-01-22 22:43:03 +01:00
Code Issues

Fixed CORE-6489: User without ALTER ANY ROLE privilege can use COMMENT ON ROLE

Browse Source
This commit is contained in:
AlexPeshkoff 2021-03-12 17:38:52 +03:00
parent 85781bffd8
commit 3f2e1ea842
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/jrd/ini.epp
View File

@ -471,7 +471,8 @@ void INI_format(const char* owner, const char* charset)
charset->name;
++charset)
{
add_security_to_sys_obj(tdbb, reqAddSC, reqModObjSC, reqInsUserPriv, ownerName, obj_charset, charset->name, length, buffer);
add_security_to_sys_obj(tdbb, reqAddSC, reqModObjSC, reqInsUserPriv, ownerName, obj_charset,
charset->name, length, buffer);
}
reqModObjSC.reset();
@ -479,9 +480,14 @@ void INI_format(const char* owner, const char* charset)
collation->name;
++collation)
{
add_security_to_sys_obj(tdbb, reqAddSC, reqModObjSC, reqInsUserPriv, ownerName, obj_collation, collation->name, length, buffer);
add_security_to_sys_obj(tdbb, reqAddSC, reqModObjSC, reqInsUserPriv, ownerName, obj_collation,
collation->name, length, buffer);
}
reqModObjSC.reset();
add_security_to_sys_obj(tdbb, reqAddSC, reqModObjSC, reqInsUserPriv, ownerName, obj_sql_role,
ADMIN_ROLE, length, buffer);
// Must be last!
acl = aclPublicStart;
memcpy(acl, PKG_PUBLIC_EXECUTE_ACL, sizeof(PKG_PUBLIC_EXECUTE_ACL));
@ -1205,6 +1211,18 @@ static void add_security_to_sys_obj(thread_db* tdbb,
}
END_FOR
}
else if (obj_type == obj_sql_role)
{
FOR(REQUEST_HANDLE reqModObjSC) R IN RDB$ROLES
WITH R.RDB$ROLE_NAME EQ obj_name.c_str()
{
MODIFY R USING
R.RDB$SECURITY_CLASS.NULL = FALSE;
PAD(security_class.c_str(), R.RDB$SECURITY_CLASS);
END_MODIFY
}
END_FOR
}
else if (obj_type == obj_package_header)
{
FOR(REQUEST_HANDLE reqModObjSC) PKG IN RDB$PACKAGES