firebird/firebird-mirror
firebird/firebird-mirror
8
0
Fork 1
mirror of https://github.com/FirebirdSQL/firebird.git synced 2025-01-23 22:03:03 +01:00
Code Issues

Lock att_mutex in Attachment's constructor

Browse Source
This commit is contained in:
hvlad 2008-05-08 07:45:19 +00:00
parent 489245fa50
commit 422338e5e3
3 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/jrd/cch.cpp
View File

@ -3982,7 +3982,6 @@ static THREAD_ENTRY_DECLARE cache_reader(THREAD_ENTRY_PARAM arg)
tdbb->setDatabase(dbb);
Attachment* const attachment = Attachment::create(dbb);
tdbb->setAttachment(attachment);
attachment->att_mutex.enter();
attachment->att_filename = dbb->dbb_filename;
Jrd::ContextPoolHolder context(tdbb, dbb->dbb_bufferpool);
@ -4146,7 +4145,6 @@ static THREAD_ENTRY_DECLARE cache_writer(THREAD_ENTRY_PARAM arg)
tdbb->setDatabase(dbb);
Attachment* const attachment = Attachment::create(dbb);
tdbb->setAttachment(attachment);
attachment->att_mutex.enter();
attachment->att_filename = dbb->dbb_filename;
Jrd::ContextPoolHolder context(tdbb, dbb->dbb_bufferpool);

3
src/jrd/jrd.cpp
View File

@ -807,7 +807,6 @@ ISC_STATUS GDS_ATTACH_DATABASE(ISC_STATUS* user_status,
attachment->att_remote_address = options.dpb_remote_address;
attachment->att_remote_pid = options.dpb_remote_pid;
attachment->att_remote_process = options.dpb_remote_process;
attachment->att_mutex.enter();
attachment->att_next = dbb->dbb_attachments;
dbb->dbb_attachments = attachment;
@ -1968,6 +1967,7 @@ ISC_STATUS GDS_CREATE_DATABASE(ISC_STATUS* user_status,
databases_mutex->leave();
*handle = attachment;
attachment->att_mutex.leave();
} // try
catch (const DelayFailedLogin& ex)
@ -4947,6 +4947,7 @@ Attachment::Attachment(MemoryPool* pool, Database* dbb)
att_remote_process(*pool),
att_dsql_cache(*pool)
{
att_mutex.enter();
}

1
src/jrd/vio.cpp
View File

@ -3897,7 +3897,6 @@ static THREAD_ENTRY_DECLARE garbage_collector(THREAD_ENTRY_PARAM arg)
Attachment* const attachment = Attachment::create(dbb);
tdbb->setAttachment(attachment);
attachment->att_mutex.enter();
attachment->att_filename = dbb->dbb_filename;
attachment->att_flags = ATT_garbage_collector;