firebird/firebird-mirror
firebird/firebird-mirror
8
0
Fork 1
mirror of https://github.com/FirebirdSQL/firebird.git synced 2025-01-22 21:23:04 +01:00
Code Issues

Don't introduce method that might not be used after schemas implementation

Browse Source
This commit is contained in:
Vlad Khorsun 2024-08-05 14:30:14 +03:00
parent 1472d1ae36
commit 548df5d409
2 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/dsql/ExprNodes.cpp
View File

@ -8092,16 +8092,6 @@ dsc* LiteralNode::execute(thread_db* /*tdbb*/, Request* /*request*/) const
return const_cast<dsc*>(&litDesc);
}
bool LiteralNode::getMetaName(thread_db* tdbb, MetaName& name) const
{
if (!DTYPE_IS_TEXT(litDesc.dsc_dtype))
return false;
CVT2_make_metaname(&litDesc, name, tdbb->getAttachment()->att_dec_status);
return true;
}
void LiteralNode::fixMinSInt64(MemoryPool& pool)
{
// MIN_SINT64 should be stored as BIGINT, not 128-bit integer
@ -12314,9 +12304,11 @@ DmlNode* SysFuncCallNode::parse(thread_db* tdbb, MemoryPool& pool, CompilerScrat
auto literal = nodeAs<LiteralNode>(node->args->items[0]);
MetaName relName;
if (literal && literal->getMetaName(tdbb, relName))
if (literal && literal->litDesc.isText())
{
MetaName relName;
CVT2_make_metaname(&literal->litDesc, name, tdbb->getAttachment()->att_dec_status);
const jrd_rel* const relation = MET_lookup_relation(tdbb, relName);
if (relation)

2
src/dsql/ExprNodes.h
View File

@ -965,8 +965,6 @@ public:
return *reinterpret_cast<SLONG*>(litDesc.dsc_address);
}
bool getMetaName(thread_db* tdbb, MetaName& name) const;
void fixMinSInt32(MemoryPool& pool);
void fixMinSInt64(MemoryPool& pool);
void fixMinSInt128(MemoryPool& pool);