firebird/firebird-mirror
firebird/firebird-mirror
8
0
Fork 1
mirror of https://github.com/FirebirdSQL/firebird.git synced 2025-02-02 10:00:38 +01:00
Code Issues

Ensure the CS listener uses the SO_REUSEADDR socket option (#8181)

Browse Source
This commit is contained in:
Dmitry Yemanov 2024-07-13 14:32:28 +03:00
parent c7d5566791
commit 5cd6497cea
1 changed files with 17 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/remote/inet.cpp
View File

@ -1073,7 +1073,7 @@ static rem_port* listener_socket(rem_port* port, USHORT flag, const addrinfo* pa
* binds the socket and calls listen().
* For multi-client server (SuperServer or SuperClassic) return listener
* port.
* For classic server - accept incoming connections and fork worker
* For Classic server - accept incoming connections and fork worker
* processes, return NULL at exit;
* On error throw exception.
*
@ -1087,27 +1087,28 @@ static rem_port* listener_socket(rem_port* port, USHORT flag, const addrinfo* pa
if (n == -1)
gds__log("setsockopt: error setting IPV6_V6ONLY to %d", ipv6_v6only);
#ifndef WIN_NT
// dimitr: on Windows, lack of SO_REUSEADDR works the same way as it was specified on POSIX,
// i.e. it allows binding to a port in a TIME_WAIT/FIN_WAIT state. If this option
// is turned on explicitly, then a port can be re-bound regardless of its state,
// e.g. while it's listening. This is surely not what we want.
// We set this options for any kind of listener, including standalone Classic.
int optval = TRUE;
n = setsockopt(port->port_handle, SOL_SOCKET, SO_REUSEADDR,
(SCHAR*) &optval, sizeof(optval));
if (n == -1)
{
inet_error(true, port, "setsockopt REUSE", isc_net_connect_listen_err, INET_ERRNO);
}
#endif
if (flag & SRVR_multi_client)
{
struct linger lingerInfo;
lingerInfo.l_onoff = 0;
lingerInfo.l_linger = 0;
#ifndef WIN_NT
// dimitr: on Windows, lack of SO_REUSEADDR works the same way as it was specified on POSIX,
// i.e. it allows binding to a port in a TIME_WAIT/FIN_WAIT state. If this option
// is turned on explicitly, then a port can be re-bound regardless of its state,
// e.g. while it's listening. This is surely not what we want.
int optval = TRUE;
n = setsockopt(port->port_handle, SOL_SOCKET, SO_REUSEADDR,
(SCHAR*) &optval, sizeof(optval));
if (n == -1)
{
inet_error(true, port, "setsockopt REUSE", isc_net_connect_listen_err, INET_ERRNO);
}
#endif
// Get any values for SO_LINGER so that they can be reset during
// disconnect. SO_LINGER should be set by default on the socket