firebird/firebird-mirror
firebird/firebird-mirror
8
0
Fork 1
mirror of https://github.com/FirebirdSQL/firebird.git synced 2025-01-22 22:03:03 +01:00
Code Issues

Implemented methods should not be marked as pure-virtual.

Browse Source 
Lets print impureOffset for StmtNode.
This commit is contained in:
hvlad 2020-06-02 14:24:42 +03:00
parent 365abd814a
commit 798c51fba0
2 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/dsql/Nodes.h
View File

@ -153,7 +153,7 @@ public:
doDsqlPass(dsqlScratch, target, node);
}
virtual Firebird::string internalPrint(NodePrinter& printer) const = 0;
virtual Firebird::string internalPrint(NodePrinter& printer) const;
virtual void getChildren(NodeRefsHolder& holder, bool dsql) const
{
@ -545,7 +545,7 @@ public:
*node = (*node)->pass2(tdbb, csb);
}
virtual Firebird::string internalPrint(NodePrinter& printer) const = 0;
virtual Firebird::string internalPrint(NodePrinter& printer) const;
virtual bool dsqlAggregateFinder(AggregateFinder& visitor)
{
@ -743,7 +743,7 @@ public:
}
public:
virtual Firebird::string internalPrint(NodePrinter& printer) const = 0;
virtual Firebird::string internalPrint(NodePrinter& printer) const;
virtual Kind getKind()
{
@ -965,7 +965,7 @@ public:
holder.add(arg);
}
virtual Firebird::string internalPrint(NodePrinter& printer) const = 0;
virtual Firebird::string internalPrint(NodePrinter& printer) const;
virtual bool dsqlAggregateFinder(AggregateFinder& visitor);
virtual bool dsqlAggregate2Finder(Aggregate2Finder& visitor);
@ -1092,7 +1092,7 @@ public:
stream = value;
}
virtual Firebird::string internalPrint(NodePrinter& printer) const = 0;
virtual Firebird::string internalPrint(NodePrinter& printer) const;
virtual RecordSourceNode* dsqlPass(DsqlCompilerScratch* dsqlScratch)
{
@ -1494,6 +1494,8 @@ public:
return KIND_STATEMENT;
}
virtual Firebird::string internalPrint(NodePrinter& printer) const;
virtual StmtNode* dsqlPass(DsqlCompilerScratch* dsqlScratch)
{
DmlNode::dsqlPass(dsqlScratch);

13
src/dsql/StmtNodes.cpp
View File

@ -280,6 +280,19 @@ namespace
namespace Jrd {
string StmtNode::internalPrint(NodePrinter& printer) const
{
DmlNode::internalPrint(printer);
NODE_PRINT(printer, impureOffset);
return "StmtNode";
}
//--------------------
StmtNode* SavepointEncloseNode::make(MemoryPool& pool, DsqlCompilerScratch* dsqlScratch, StmtNode* node)
{
if (dsqlScratch->errorHandlers)