firebird/firebird-mirror
firebird/firebird-mirror
8
0
Fork 1
mirror of https://github.com/FirebirdSQL/firebird.git synced 2025-01-22 23:23:02 +01:00
Code Issues

Constness

Browse Source
This commit is contained in:
Dmitry Yemanov 2021-10-13 07:23:20 +03:00
parent cfc0bbc82b
commit 8b485a455c
5 changed files with 22 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/dsql/BoolNodes.h
View File

@ -95,7 +95,7 @@ public:
virtual BoolExprNode* dsqlPass(DsqlCompilerScratch* dsqlScratch);
virtual void genBlr(DsqlCompilerScratch* dsqlScratch);
virtual bool possiblyUnknown()
virtual bool possiblyUnknown() const
{
return blrOp == blr_equiv ? true : BoolExprNode::possiblyUnknown();
}
@ -143,7 +143,7 @@ public:
virtual BoolExprNode* dsqlPass(DsqlCompilerScratch* dsqlScratch);
virtual void genBlr(DsqlCompilerScratch* dsqlScratch);
virtual bool possiblyUnknown()
virtual bool possiblyUnknown() const
{
return true;
}
@ -176,7 +176,7 @@ public:
virtual BoolExprNode* dsqlPass(DsqlCompilerScratch* dsqlScratch);
virtual void genBlr(DsqlCompilerScratch* dsqlScratch);
virtual bool possiblyUnknown()
virtual bool possiblyUnknown() const
{
return true;
}
@ -224,7 +224,7 @@ public:
return true;
}
virtual bool possiblyUnknown()
virtual bool possiblyUnknown() const
{
return true;
}

4
src/dsql/ExprNodes.cpp
View File

@ -289,7 +289,7 @@ bool ExprNode::sameAs(const ExprNode* other, bool ignoreStreams) const
return true;
}
bool ExprNode::possiblyUnknown()
bool ExprNode::possiblyUnknown() const
{
NodeRefsHolder holder;
getChildren(holder, false);
@ -303,7 +303,7 @@ bool ExprNode::possiblyUnknown()
return false;
}
bool ExprNode::unmappable(const MapNode* mapNode, StreamType shellStream)
bool ExprNode::unmappable(const MapNode* mapNode, StreamType shellStream) const
{
NodeRefsHolder holder;
getChildren(holder, false);

16
src/dsql/ExprNodes.h
View File

@ -312,7 +312,7 @@ public:
virtual ValueExprNode* pass2(thread_db* tdbb, CompilerScratch* csb);
virtual dsc* execute(thread_db* tdbb, jrd_req* request) const;
virtual bool possiblyUnknown()
virtual bool possiblyUnknown() const
{
return true;
}
@ -776,7 +776,7 @@ public:
dsqlDesc = desc;
}
virtual bool possiblyUnknown()
virtual bool possiblyUnknown() const
{
return false;
}
@ -787,7 +787,7 @@ public:
streamList.add(fieldStream);
}
virtual bool unmappable(const MapNode* /*mapNode*/, StreamType /*shellStream*/)
virtual bool unmappable(const MapNode* /*mapNode*/, StreamType /*shellStream*/) const
{
return true;
}
@ -1642,7 +1642,7 @@ public:
virtual void genBlr(DsqlCompilerScratch* dsqlScratch);
virtual void make(DsqlCompilerScratch* dsqlScratch, dsc* desc);
virtual bool possiblyUnknown()
virtual bool possiblyUnknown() const
{
return false;
}
@ -1900,12 +1900,12 @@ public:
virtual bool dsqlFieldFinder(FieldFinder& visitor);
virtual ValueExprNode* dsqlFieldRemapper(FieldRemapper& visitor);
virtual bool unmappable(const MapNode* /*mapNode*/, StreamType /*shellStream*/)
virtual bool unmappable(const MapNode* /*mapNode*/, StreamType /*shellStream*/) const
{
return false;
}
virtual bool possiblyUnknown()
virtual bool possiblyUnknown() const
{
return true;
}
@ -2114,7 +2114,7 @@ public:
virtual void genBlr(DsqlCompilerScratch* dsqlScratch);
virtual void make(DsqlCompilerScratch* dsqlScratch, dsc* desc);
virtual bool possiblyUnknown()
virtual bool possiblyUnknown() const
{
return true;
}
@ -2163,7 +2163,7 @@ public:
virtual void genBlr(DsqlCompilerScratch* dsqlScratch);
virtual void make(DsqlCompilerScratch* dsqlScratch, dsc* desc);
virtual bool possiblyUnknown()
virtual bool possiblyUnknown() const
{
return true;
}

14
src/dsql/Nodes.h
View File

@ -659,15 +659,15 @@ public:
}
// Check if expression could return NULL or expression can turn NULL into a true/false.
virtual bool possiblyUnknown();
virtual bool possiblyUnknown() const;
// Verify if this node is allowed in an unmapped boolean.
virtual bool unmappable(const MapNode* mapNode, StreamType shellStream);
virtual bool unmappable(const MapNode* mapNode, StreamType shellStream) const;
// Return all streams referenced by the expression.
virtual void collectStreams(SortedStreamList& streamList) const;
virtual bool findStream(StreamType stream)
virtual bool containsStream(StreamType stream) const
{
SortedStreamList streams;
collectStreams(streams);
@ -1027,7 +1027,7 @@ public:
virtual AggNode* pass2(thread_db* tdbb, CompilerScratch* csb);
virtual bool possiblyUnknown()
virtual bool possiblyUnknown() const
{
return true;
}
@ -1039,7 +1039,7 @@ public:
return;
}
virtual bool unmappable(const MapNode* /*mapNode*/, StreamType /*shellStream*/)
virtual bool unmappable(const MapNode* /*mapNode*/, StreamType /*shellStream*/) const
{
return false;
}
@ -1160,12 +1160,12 @@ public:
fb_assert(false);
}
virtual bool possiblyUnknown()
virtual bool possiblyUnknown() const
{
return true;
}
virtual bool unmappable(const MapNode* /*mapNode*/, StreamType /*shellStream*/)
virtual bool unmappable(const MapNode* /*mapNode*/, StreamType /*shellStream*/) const
{
return false;
}

2
src/jrd/opt.cpp
View File

@ -2413,7 +2413,7 @@ static RecordSource* gen_retrieval(thread_db* tdbb,
// that are local to this stream. The remaining ones are left in piece
// as possible candidates for a merge/hash join.
if ((inversion && node->findStream(stream)) ||
if ((inversion && node->containsStream(stream)) ||
(!inversion && node->computable(csb, stream, true)))
{
compose(*tdbb->getDefaultPool(), &boolean, node);