firebird/firebird-mirror
firebird/firebird-mirror
8
0
Fork 1
mirror of https://github.com/FirebirdSQL/firebird.git synced 2025-01-22 18:03:03 +01:00
Code Issues

Months ago I marked a buffer overrun in deliver_request().

Browse Source 
Now I think I've fixed it.
This commit is contained in:
robocop 2004-10-04 04:39:55 +00:00
parent 5631d1fa70
commit 9b112424fa
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/jrd/event.cpp
View File

@ -1034,8 +1034,10 @@ static void deliver_request(EVT_REQ request)
fb_assert(event_buffer == buffer); /* we're in this block only once */
// CVC: We don't check at run-time in the release version, it's
// likely to produce a buffer overrun if we reach MAX_EVENT_BUFFER,
// since new_buffer will be again and again this number.
UCHAR* new_buffer = (UCHAR*)gds__alloc((SLONG) MAX_EVENT_BUFFER);
// since new_buffer will be again and again this number. FIXED.
UCHAR* new_buffer = 0;
if (event_buffer == buffer)
new_buffer = (UCHAR*)gds__alloc((SLONG) MAX_EVENT_BUFFER);
/* FREE: at procedure exit */
if (!new_buffer)
{ /* NOMEM: */