firebird/firebird-mirror
firebird/firebird-mirror
8
0
Fork 1
mirror of https://github.com/FirebirdSQL/firebird.git synced 2025-01-22 18:43:02 +01:00
Code Issues

Fixed error.

Browse Source 
Correct comments: cursor stability -> read consistency
This commit is contained in:
hvlad 2017-04-12 18:25:02 +03:00
parent e31dec1a44
commit f9ca873c65
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/jrd/req.h
View File

@ -288,7 +288,7 @@ public:
USHORT charSetId; // "client" character set of the request
TriggerAction req_trigger_action; // action that caused trigger to fire
// Fields to support READ COMMITTED cursor stability
// Fields to support read consistency in READ COMMITTED transactions
jrd_req* req_snapshot_owner;
SnapshotHandle req_snapshot_handle;
CommitNumber req_snapshot_number;

10
src/jrd/tra.cpp
View File

@ -133,7 +133,7 @@ CommitNumber ActiveSnapshots::getSnapshotForVersion(CommitNumber version_cn)
void TRA_setup_request_snapshot(Jrd::thread_db* tdbb, Jrd::jrd_req* request)
{
// This function is called whenever request is started in a transaction.
// Setup context to preserve cursor stability in READ COMMITTED transactions.
// Setup context to preserve read consistency in READ COMMITTED transactions.
Jrd::jrd_tra* transaction = request->req_transaction;
@ -179,7 +179,7 @@ void TRA_setup_request_snapshot(Jrd::thread_db* tdbb, Jrd::jrd_req* request)
}
// If we are a top-level request or caller is executed in a different transaction,
// we need to set up statement snapshot for cursor stability and own it
// we need to set up statement snapshot for read consistency and own it
request->req_snapshot_owner = request;
@ -1592,7 +1592,7 @@ int TRA_snapshot_state(thread_db* tdbb, jrd_tra* trans, TraNumber number, Commit
default:
state = tra_committed;
if (snapshot)
*snapshot = trans->tra_active_snapshots.getSnapshotForVersion(CN_PREHISTORIC);
*snapshot = trans->tra_active_snapshots.getSnapshotForVersion(stateCn);
break;
}
}
@ -3375,8 +3375,8 @@ static void transaction_start(thread_db* tdbb, jrd_tra* trans)
// If the transaction is read-only and read committed, it can be
// precommitted because it can't modify any records.
// 2014-08-26 NS XXX: with latest changes in TIP cache semantics and cursors
// stability changes precommitted transactions offer almost no benefit, but
// 2014-08-26 NS XXX: with latest changes in TIP cache semantics and read
// consistency changes precommitted transactions offer almost no benefit, but
// complicate implementation considerably. It might make sense to remove
// precommitted transactions logic completely.