robocop
0914c3a9dd
People using other compilers shouldn't be bothered with workarounds for one compiler, while possible. We already have workarounds for gcc, SunOS4 headers, HP/UX compiler, SCO compiler, Apollo compiler... why adding more for everyone?
2006-06-15 04:56:24 +00:00
asfernandes
6704275f76
Make compilable in MSVC6
2006-06-06 15:42:50 +00:00
alexpeshkoff
ded5cc2c49
cleanup
2006-06-06 10:34:32 +00:00
dimitr
8d1c1ed8c4
Dropped SMALL_FILE_NAMES related constants.
2006-06-02 04:23:41 +00:00
dimitr
3937771826
More complete fix.
2006-06-01 05:56:55 +00:00
dimitr
96b99def48
Fixed issues reported by Michal.
2006-06-01 05:12:38 +00:00
dimitr
7cc12e8489
1) Reworked memory management in SORT. Now we're pools aware there.
...
2) Reworked error handling in SORT and its callers.
3) Replaced DLS+SortMem with the generic TempSpace class.
4) Replaced GDS temp file management with the TempFile class.
5) Various cleanup.
2006-05-31 08:53:00 +00:00
hvlad
701f2cbda4
Global temporary tables implementation
2006-05-21 22:07:35 +00:00
alexpeshkoff
b056a118b5
1. Avoid use of STL
...
2. Reworked exceptions to make status_exception always hold correct status vector
3. Avoid use of RTTI
2006-05-19 15:17:02 +00:00
robocop
ebe0a75026
Simplification.
2006-05-04 00:02:58 +00:00
aafemt
46c3ee5090
Fix for my previous commit. Thanks to Adriano
2006-04-28 04:12:09 +00:00
aafemt
f5838a4262
Not elegant fix for treating too big statements as an error
2006-04-27 10:57:11 +00:00
robocop
4505c223f0
Correction.
2006-04-11 08:21:23 +00:00
robocop
62ae60c818
Adriano reported a problem with SHOW GENERATORS skipping the required object because an old db had NULL in the sysflag column. Using his proposed fix, committed only to the HEAD.
2006-04-11 07:30:58 +00:00
robocop
a90a72232c
Adjust isql to the full words stated in the IB5 docs for the command line options.
2006-04-08 00:03:50 +00:00
alexpeshkoff
543932292f
fixed regression in switch
2006-04-06 14:43:01 +00:00
robocop
c5f2284b15
Style.
2006-04-06 08:18:53 +00:00
mkubecek
4a94466a5a
Fix of isql command line parser: check for repeated switches or database name.
2006-03-28 04:31:35 +00:00
robocop
2484232f23
- Misc.
...
- Style
- Avoiding one indentation level.
2006-03-26 05:58:29 +00:00
asfernandes
3329d9fc07
Correction
2006-03-26 03:34:14 +00:00
mkubecek
332dce9203
Fix of isql command line parser: allow only abbreviations of standard switch names, check integer arguments to be integers.
2006-03-25 23:41:36 +00:00
robocop
6bd28bca87
Misc.
2006-03-25 07:01:34 +00:00
robocop
3ed50872b2
Give isql a more useful help when receiving incorrect command line arguments, in sync with other utilities. Courtesy of Michal Kubecek.
...
Example: isql -?
2006-03-16 09:07:37 +00:00
robocop
c5c56a0043
Fix misleading error message reported by Michal Kubecek.
2006-02-24 09:21:16 +00:00
hvlad
73dcebc962
Replace "../jrd/jrd_time.h" with "../common/classes/timestamp.h"
2006-02-03 13:13:27 +00:00
alexpeshkoff
d1ee840d60
fixed gcc warning(s)
2006-01-16 16:49:15 +00:00
robocop
1ca7a582f9
EXPRESSION_INDICES code is considered stable and therefore there's no need to keep it protected by macros. Please do a full rebuild.
2006-01-14 07:00:44 +00:00
alexpeshkoff
32ef4f5b67
fixed compilation after changes in exception
2006-01-07 16:58:23 +00:00
robocop
f902dd1311
Parse the server version output (that can be large with redirection) correctly when isql -z is used.
2005-12-30 06:57:06 +00:00
alexpeshkoff
9fa49f5077
make server-version output a bit more readable
2005-12-29 09:32:41 +00:00
alexpeshkoff
4447d705c8
fixed bugs in server version reporting
2005-12-29 08:06:11 +00:00
dimitr
0a19363d98
Fixed stack buffer overrun.
2005-12-27 09:42:40 +00:00
alexpeshkoff
2d259e3978
Fixed buffer overrun in case of bad data returned by isc_database_info()
2005-12-26 16:10:59 +00:00
robocop
39b9a7fb22
Avoid the intermediate buffer.
2005-12-03 07:01:16 +00:00
alexpeshkoff
62a24d46e4
1. Moved data structures, written to database file, into ods.h.
...
2. Added new types of clumplets to ClumpletReader and ClupmletWriter.
3. Applied modified ClumpletReader and ClupmletWriter to /remote and partially /jrd.
4. Added active protection from remote brute-force attack to services API.
2005-11-27 20:53:09 +00:00
robocop
c6a7afcb8a
Fix for problems with triggers v/s checks (some triggers not extracted, other automatically generated triggers belonging to CHECK, view's CHECK OPTION and CASCADE being extracted).
2005-11-27 06:42:16 +00:00
robocop
e7fa075880
Let isql yell always, irregardless of the switches.
2005-11-08 23:57:23 +00:00
robocop
c6e7a41878
Fix display alignment problem with CHAR type and small binary fields.
2005-10-08 07:02:54 +00:00
robocop
4337f38101
Update isql accordingly to my previous Fix SF Bug #1292007
...
Move more hardcoded error strings to the msg database.
2005-10-06 07:02:04 +00:00
robocop
c974a600e3
SHOW command should also show procedure parameters defaults.
2005-09-30 08:43:03 +00:00
robocop
95ce9df850
Update isql to extract procedure parameters defaults in a script as a tribute to Vlad.
...
Note: Vlad is still alive.
2005-09-30 07:52:22 +00:00
robocop
9af8440596
Better check for isql ignoring implicit rdb$<number> domains.
2005-09-24 05:09:43 +00:00
robocop
d7f1979164
Fix premature EOF while reading a script file when using the SHELL command inside it, found by Paul Reeves. Trying to find a compromise between MS requirements for system() call and its bad side effects on our isql.
2005-09-03 05:54:27 +00:00
robocop
0285583c9f
Fix display bug found by Adriano, caused by missing %s and try to make isql output more consistent. QA Tools that check for strict result may complain.
2005-07-08 04:10:27 +00:00
asfernandes
8fe0408bb3
Make SQLDA_DISPLAY display input SQLDA parameters of INSERTs, UPDATEs and DELETEs
2005-06-23 15:12:53 +00:00
robocop
2870acfc87
Fix blob dumping routines in jrd and report errors in isql.
2005-06-16 05:13:35 +00:00
robocop
545cb77032
If an error happens when we are trying to retrieve the first record, we need to print a newline or the error msg will appear padding the column headers.
2005-06-12 23:47:04 +00:00
robocop
f3593f8977
Cater for the longest possible identifiers, quoted.
2005-06-12 01:36:03 +00:00
robocop
c547304496
- Renamed function input to newinput to be in sync with newoutput.
...
- Implemented PASSTHROUGH command only for the debug build. Use with care.
2005-06-11 00:32:06 +00:00
robocop
56deb9afcd
Mixed case generator names caused problems in show_generators.
...
Noticed by Adriano.
2005-06-06 08:32:55 +00:00
robocop
729238ae80
I didn't test a case, but I'm pretty sure that long quoted identifiers could lead to a buffer overrun while extracting grants here.
2005-05-26 08:26:05 +00:00
robocop
d677f7ba8b
Fix SF Bug #1208932 reported by Ivan Prenosil an hour ago approx.
2005-05-26 07:35:45 +00:00
robocop
35dc1e343c
- Cleanup.
...
- A bit better handling of SHOW EXCEPTION.
2005-05-26 06:45:25 +00:00
robocop
f6d654cf13
Lower the clutter.
2005-05-24 04:42:01 +00:00
robocop
e449e24d0b
Escape single quotes in comment's text and double quotes in identifiers that have metadata comments not when we are doing SHOW COMMENT[S] but only when we are extracting a script, as Martijn suggested.
2005-05-20 08:34:19 +00:00
robocop
1ac3a5d9b7
- Implement the SHOW COMMENT(S) command.
...
- Integrate it into metadata extraction, too.
- A couple of minor improvements to isql.
See explanation in show_comments() function.
2005-05-19 08:03:10 +00:00
dimitr
00e8d18464
Implemented metadata extract for expression indices.
2005-05-18 15:53:41 +00:00
kkuznetsov
a066a949fb
Renamed ERR to ps_ERR in the enum processing_state {...} to fix compile error on Solaris
2005-05-14 14:50:41 +00:00
robocop
df8b6d12e4
Apply Miroslav Penchev fix for ISQL_disconnect_database overwriting the Quiet flag permanently.
2005-05-12 07:00:54 +00:00
robocop
3c361f66ba
Simplify array bounds printing for canonic case.
2005-05-12 05:32:25 +00:00
robocop
3fd1859bd1
Workaround for SF Bug #450404 . (Isql can't guess what the user intended.)
2005-05-02 07:11:39 +00:00
robocop
3f68b85b89
Another fix for the -b (Bail On Error) option when SQL commands are issued and no db connection exists yet.
...
Apply Miroslav Penchev's patch for bug with -Q always returning 1 to the operating system, discovered by Ivan Prenosil.
2005-04-28 06:26:24 +00:00
robocop
b2010a42e4
Fix indentation.
2005-04-25 05:23:57 +00:00
robocop
26c5ac04b0
This is my first attempt in four years to fix the nonsense code I wrote for grants extraction in FB1.
2005-04-04 08:33:43 +00:00
robocop
3379bed424
Isql shouldn't try to connect twice when extracting metadata, since the second attempt may produce a confusing message (the db name has been made null at this time).
2005-04-04 08:31:11 +00:00
robocop
4fbf25e341
Fix chaotic output.
2005-04-03 06:58:40 +00:00
robocop
7acd0a6d39
- Temporary fix for Pavel's firebird-Field-test-1173948.
...
- Some little tweaks.
2005-04-02 07:07:07 +00:00
robocop
f800fd59a7
I find hard to work with functions that span 800 or more lines. Therefore, I modularized process_statement. I took the opportunity to get rid of some local variables and fix performance info printing.
2005-04-02 03:51:43 +00:00
robocop
c5c02ed2e9
1.- Replacing raw call to gds__msg_format by ISQL_msg_get; the routine was there for years and almost unused.
...
2.- UDFs are still created by sys_flag being NULL, so show_functions() should acknowledge that fact.
3.- Implement naive code to show an approximate script-related line number when a failure happens. (Unlike my private FB1's isql, it doesn't rely on strings subject to localization.)
4.- With SET PLANONLY ON, PLAN was activated, but with SET PLAN OFF, PLANONLY wasn't deactivated.
5.- Include isc_info_sql_stmt_get_segment among statements that are like SELECT.
6.- Solve a bad interaction between PLANONLY and SQLDA_DISPLAY, where the first being activated didn't allow to see the output XSQLDA.
7.- More error detection.
2005-03-31 07:50:32 +00:00
robocop
5672f269e0
More WAL deletion.
2005-03-26 05:50:16 +00:00
robocop
29690221e1
1.- Some small buffers with predefined lengths don't need to be allocated dynamically.
...
2.- ISQL_get_index_segments shouldn't overflow in extreme cases. Better print an indication that the extraction wasn't completed (ellipsis).
3.- Fix bug with EXTRACT_list table that was printing ); if it didn't find the required table. This in turn caused bugs in other functions.
4.- STDERROUT is used in all places with second argument set to true. Simplify it.
5.- Delete the code previously commented for WAL.
6.- Fix add_row and copy_table. These features were requested to be made available in release mode at v1 time by Paul Beach. They should now be able to cope with quoted identifiers, too.
7.- Complement usage of readNextInputLine when called directly to avoid reading garbage or causing memory errors.
8.- Fix several strings that should have been declared with MAXPATHLEN since the first moment.
9.- Misc bug fixes and B.O. closed.
2005-03-26 05:33:55 +00:00
aafemt
ad88d1e805
Fix for Field-test item #1168910
2005-03-23 10:10:38 +00:00
skidder
56186e7f4d
Calling clear_history like that breaks the builds. But even when build is fixed, call like that causes SIGSEGV due to editline history not being initalized when ISQL is used in non-interactive mode. Since clear_history doesn't free all the editline memory there is no big point in using it here anyways...
2005-03-09 06:53:03 +00:00
robocop
39c62a936d
Totally misc.
2005-03-04 09:21:12 +00:00
robocop
ea866740f1
1.- Stop possible crash with long terminators. Pending other checks for the future.
...
2.- Complete Damyan Ivanov's patch to allow BAIL detect really most error conditions.
3.- Create two functions to handle part of the bulky processing of isql's built-in commands.
4.- Make SET SQLDA_DISPLAY work in release versions and derive functionality to two new functions.
5.- Change Borland's moronic usage of a FIFO implemented in a linked list to handle the needs of a LIFO, simplying code and avoiding the associated logic pain.
6.- Avoid several SQL> prompts when using the INPUT command interactively.
7.- Free several resources on exit. Stop some additional memory leaks.
8.- Signal we are processing the INPUT command only when the file can be opened.
9.- Put the cursor declaration inside the code protected for scrollable cursors, in case it's needed there, since isql doesn't do positioned updates.
Remember to report random behavior, crashes, segmentation faults, core dumps and BSOD's.
2005-03-04 09:17:34 +00:00
robocop
4be87294fa
sqldaid and sqldabc are unused crap borrowed from IBM 15 years ago.
...
Don't show them as they contain garbage.
2005-02-07 09:00:33 +00:00
aafemt
d455bd79e4
LF already have been killed in readNextInputLine()
2005-01-26 10:37:53 +00:00
robocop
1361f698e1
Show system UDF's. According to Ann, she seems to remember that
...
"there hasn't been a missing RDB$SYSTEM_FLAG since V2 except
objects created with direct system table inserts."
but if there are problems, I will have to do two loops.
2005-01-04 05:42:26 +00:00
robocop
4012106884
Misc.
2004-12-25 09:44:03 +00:00
robocop
d65307b497
Style.
2004-12-24 08:52:39 +00:00
aafemt
1bb898274b
Fix extra EOLN in interactive mode without editline
2004-12-23 10:15:49 +00:00
robocop
ba7f94f470
Misc.
2004-12-17 05:57:04 +00:00
aafemt
59f854c331
Fix for AV on EOF in interactive mode
2004-12-16 12:45:30 +00:00
aafemt
52aaaacfad
Parser must parse, not input routine
2004-12-16 10:23:58 +00:00
aafemt
491cfb9abd
Redundant comment
2004-12-16 10:13:51 +00:00
robocop
bd491bec02
Restore output if copy_table fails.
2004-12-12 02:01:52 +00:00
alexpeshkoff
387e678cca
applied Clumplet* classes to dpb where possible
2004-12-09 19:19:47 +00:00
robocop
0dd1aced53
Misc.
2004-12-09 02:50:47 +00:00
skidder
aa80ac9481
Fix POSIX build after Claudio cleanup
2004-12-09 01:53:31 +00:00
robocop
001c8257a2
1.- Get rid of the std::string from the STL.
...
2.- Add a couple of missing deallocations.
2004-12-07 00:38:03 +00:00
robocop
308bdd3de1
Misc.
2004-12-07 00:33:16 +00:00
robocop
467277c241
Misc and solve a couple of missing deallocations.
2004-12-04 08:30:43 +00:00
robocop
9834b16376
Close the blob before returning an error.
2004-12-03 07:23:22 +00:00
robocop
7f0624da56
Misc.
2004-12-03 07:22:49 +00:00
robocop
4076ff0a11
First attempt to fix the double charset reporting bug that our dear Blas left in isql more than half a year ago.
2004-12-01 08:25:25 +00:00
robocop
af6a16107a
Misc.
2004-11-30 06:18:39 +00:00
robocop
71989bd496
Don't show system functions.
2004-11-30 06:08:56 +00:00
skidder
51a992b959
Do not include system functions in database metadata script generated by ISQL
2004-11-30 03:22:50 +00:00
robocop
f8569104d6
Apply Adriano change with the following explanation:
...
Fix a bug that occur when a BLOB column is added after the start of the DML transaction.
2004-11-28 08:36:22 +00:00
robocop
e4ae004ca9
Completed (I hope) Damyan Ivanov's patch that didn't work with insertions, updates and deletions.
2004-11-28 07:05:42 +00:00
robocop
bb170bd3b6
isc_interpret is fb_interpret again.
...
Please do a full rebuild.
2004-11-28 01:03:05 +00:00
robocop
f6ec71ded5
Allow the -m2 option to work.
2004-11-24 09:04:06 +00:00
robocop
6f376126bc
Applying Damyan Ivanov's isql patch.
...
Document it in the interactive help isql -?
Document also the m2 option (merge diagnostics).
2004-11-24 08:58:11 +00:00
robocop
c4cbb25f92
Misc.
2004-11-23 11:03:48 +00:00
robocop
cdeae35b31
Allow basic leaks reporting, fix a couple of leaks and delete obsolete comment.
2004-11-22 08:00:49 +00:00
hvlad
4fcd43a3d0
Allow isql to show large exception messages
2004-11-17 12:20:49 +00:00
robocop
628b088d2c
Treat string literals and string constants with more respect.
2004-11-10 04:26:45 +00:00
robocop
5a33aeef91
Misc: extra semicolons do not help. :-)
2004-11-07 10:38:13 +00:00
robocop
1eb6693d0f
When the XSQLDA is reallocated, set the version again (from my uncommitted FB1 fixes).
2004-11-07 10:20:27 +00:00
skidder
3e26513b38
fb_interpret->isc_interpet, deprecate isc_interpete, clean interface a little bit
2004-10-25 03:53:03 +00:00
robocop
31ba754981
After talking to Ann, decided to disable several items:
...
- obsolete items like WAL and JOURNAL (cleaned in the past)
- crud from attempts never finished like the shared cache manager for Classic
- DSQL nodes that aren't used. This allowed freeing some keywords.
The functionality was disabled by commenting the code. No code has been deleted.
2004-10-03 04:49:04 +00:00
robocop
3c8612ad7a
Solve assertion in latest MSVC regarding isspace() with two helper functions. This is a mere reorganization of Adriano's fix.
2004-09-29 03:44:36 +00:00
skidder
02a0915156
Teach engine to work with larger record numbers - 64-bit internally, 40-bit externally
2004-09-28 06:28:38 +00:00
asfernandes
133f57e586
Fix a bug with international characters in ISQL causing assertions in VS2003
2004-09-26 02:57:40 +00:00
robocop
840bf14b36
If we are using namespace fb_utils, it doesn't make sense to prefix functions in it with fb_ again. Mechanical replacement made one by one (no bulk automatic changes).
2004-09-26 01:49:52 +00:00
robocop
e6cb17cac6
Vulnerability reported by Daniel Urban.
...
First step: reorganize code.
Please do a full rebuild after retrieving those changes.
2004-09-22 01:59:39 +00:00
robocop
f0d309811f
Corrections
2004-09-22 01:55:37 +00:00
dimitr
74a845706b
Minor fixes.
2004-09-05 15:00:51 +00:00
robocop
1c7aa47ec1
Showing role's description is dependent on the ODS
2004-08-31 06:26:27 +00:00
robocop
5ffd45799e
When a role hasn't been granted, tell that. Do not hide the role (wasted two minutes to discover it wasn't gbak problem). Also, show the role's description.
2004-08-30 10:10:14 +00:00
robocop
84a00693d9
Misc
2004-08-30 10:07:49 +00:00
robocop
3236e206c8
Add in the help the mention of SET HEADING that was introduced time ago.
2004-08-27 08:34:41 +00:00
robocop
5eb042a638
Style
2004-08-27 05:13:47 +00:00
robocop
e3b269d2a4
Show ODS as part of SHOW DATABASE command.
2004-08-27 05:03:13 +00:00
robocop
41a21aa306
Support for new UDF mechanism
2004-08-27 05:01:56 +00:00
robocop
be2f4fe195
Style and comment useless code
2004-08-27 05:00:31 +00:00
aafemt
5dafdcb461
Make prompt visible in MSYS
2004-08-26 11:10:28 +00:00
aafemt
59f08d2a29
Rework statement pre-parsing. Now it doesn't swallow tabs
2004-08-26 10:28:57 +00:00
aafemt
e9403dd1b8
Use automatic buffers instead of dynamic
2004-08-25 11:43:09 +00:00
robocop
b60c0e4cab
Misc: format
2004-08-21 09:29:46 +00:00
aafemt
cdb105b26e
Let isql return error code on script errors
2004-08-19 10:26:09 +00:00
brodsom
da46a55b16
-Correction (Found by Claudio)
2004-07-21 10:34:27 +00:00
robocop
949830d0c6
1.- const correctness
...
2.- style
3.- Try to fix the mess caused by different data types used to represent bifields of SCL_ constants defined in scl.h,
first round. No circular dependencies found through MSVC. Still pending dyn* and grant.epp files.
2004-06-29 04:37:59 +00:00
brodsom
e8a210e39d
-C++ struct declaration style.
2004-06-08 18:27:59 +00:00
robocop
c77040ff97
Style and const
2004-06-06 05:25:32 +00:00
robocop
1332d98618
Literal strings should be treated as const char*
2004-06-05 09:37:18 +00:00
robocop
3c56e6acfb
Function ADD should not mangle date inputs
2004-05-31 02:35:58 +00:00
robocop
7b51928503
Style
2004-05-29 04:55:23 +00:00
brodsom
e34284aecf
-Join isql globals in one struct (and remove some macros) and put not globals in the corresponding source.
...
-Use C++ struct declaration style.
2004-05-24 17:16:02 +00:00
brodsom
dd5d8aba0a
-Replace stuff macros with either common stuff inlines or class inline functions
2004-05-24 11:03:54 +00:00
robocop
441817bd82
1.- Misc changes
...
2.- Style
3.- Recover dsc_ttype in dsc after Blas' cleanup as a synonym for dsc_sub_type in text types
2004-05-21 06:16:17 +00:00
brodsom
a76ee0147d
-Macro cleaning
2004-05-18 21:59:25 +00:00
brodsom
eedff9ba57
-Macro cleaning
...
-Move isql_res.h to isql.rh
2004-05-18 16:21:39 +00:00
brodsom
13f149d77b
-Fix ISO C++ errors (gcc -pedantic switch)
2004-05-13 09:25:24 +00:00
brodsom
1ffe279896
-Avoid shadow warning
2004-05-12 19:39:17 +00:00
brodsom
473abc461b
Replace macro with inline-comments (Claudio found gpre have some issues with the ifdefs)
2004-05-10 00:18:34 +00:00
robocop
802f244ec1
Misc changes
2004-05-09 05:48:33 +00:00
brodsom
bdab6a747b
Replace define with const
2004-05-07 07:52:47 +00:00
brodsom
66a3ae7a1c
Fix warnings
2004-05-04 02:53:36 +00:00
skidder
43cb0d1ce4
Y-Valve handle translation layer
2004-05-02 23:06:37 +00:00
