asfernandes
d30d6410ea
Misc
2008-06-13 01:42:58 +00:00
robocop
30b5480c66
Move the new EXEC STMT functionality to a separate function.
2008-06-12 09:02:54 +00:00
hvlad
66fd7d5488
Make blr_exec_stmt extensible in the future.
...
Sorry, recompile of stored objects using new EXECUTE STATEMENT is necessary. Hope the last time ;)
2008-06-10 22:43:30 +00:00
alexpeshkoff
5f0278b14e
Added GRANTED BY clause to GRANT and REVOKE commands.
...
Fixed CORE-1869: Roles granting/revoking logic differs between 2.0 and 2.1.
2008-06-10 10:55:48 +00:00
robocop
017d04dbfc
Misc.
2008-06-10 10:11:39 +00:00
dimitr
c639285420
Fixed the Linux build.
2008-06-10 03:31:19 +00:00
alexpeshkoff
bbd35943db
fixed gcc build
2008-06-09 07:49:56 +00:00
asfernandes
26a79e3c6e
Misc
2008-06-09 01:34:33 +00:00
hvlad
5d9c430674
Implemented improvement CORE-1928 : Allow EXECUTE STATEMENT to inherit access privileges of caller stored procedure or trigger.
...
Allow to specify EXECUTE STATEMENToptional clauses in any (not fixed) order.
Use INTERNAL_PROVIDER for access to the current database by another user too.
2008-06-08 20:42:27 +00:00
asfernandes
552f58dd48
Misc
2008-06-06 02:25:35 +00:00
robocop
b8ea332022
Misc.
2008-06-05 11:02:42 +00:00
robocop
d9c191f831
Fix the logic in two unused functions (in case they aren't dropped).
2008-06-05 10:58:17 +00:00
robocop
a1906d634f
Style.
2008-06-03 06:19:50 +00:00
robocop
ab2987a3aa
Style.
...
Remove useless parentheses.
2008-06-03 06:19:21 +00:00
robocop
07c087094d
Mostly remove useless parentheses.
2008-06-03 06:14:59 +00:00
asfernandes
dbaf050e86
Set the tdbb->request to NULL when committing an autonomous transaction, as a normal COMMIT does. This fixes assertion related to system blobs created by DDL commands in EXECUTE STATEMENT. Test case:
...
execute block
as
begin
in autonomous transaction do
execute statement 'create table x (n integer)';
end!
2008-06-01 19:14:41 +00:00
asfernandes
0d84abc6d4
Fixed CORE-1919 - Memory corruptions in EXECUTE STATEMENT may crash the server
2008-06-01 01:19:54 +00:00
alexpeshkoff
b9be96d37f
Applied Damyan's patch eliminating some warnings in gcc 4.3
2008-05-28 13:22:26 +00:00
alexpeshkoff
093901c134
fixed gcc 3 build
2008-05-28 13:11:36 +00:00
asfernandes
0d979e5b92
Misc
2008-05-28 02:11:00 +00:00
asfernandes
679ac834a5
Small inconsistency noticed by Claudio
2008-05-25 15:41:54 +00:00
robocop
2cc3233658
Misc.
2008-05-25 12:17:58 +00:00
robocop
88859fdc51
Make operations a bit faster by enabling the vector to add an array of values in a single pass (the same idea as insert's overloaded version).
2008-05-25 12:16:20 +00:00
robocop
0d3d93ac90
Complete Adriano's change.
2008-05-25 11:48:01 +00:00
robocop
4acad057dc
Give explicit names to vars that save state for later restoration.
2008-05-25 11:44:11 +00:00
asfernandes
84603f1169
Misc
2008-05-25 01:39:16 +00:00
asfernandes
d4bf9ab246
Split dsql_req into dsql_req and CompiledStatement. This should be my last refactoring to 2.5:
...
- dsql_req becomes a running request;
- CompiledStatement is derived from dsql_req. The compilation state previously in dsql_req comes to here;
- Rename many "request" parameters to "statement" where type is changed from dsql_req to CompiledStatement.
This changes makes easy the path to support compiled statement cache.
2008-05-24 03:19:52 +00:00
asfernandes
71bd20b209
Fixed CORE-1910 - Not valid fields in MERGE's insert clause are allowed
2008-05-23 01:37:19 +00:00
asfernandes
bdf999ddef
Slight more correct usage of scope level in MERGE
2008-05-23 00:38:06 +00:00
asfernandes
36e7ddd38c
Corrections
2008-05-22 23:19:09 +00:00
asfernandes
9fc4a1881f
Misc
2008-05-22 21:45:22 +00:00
robocop
5cd11867ec
Get rid of (ALLOC/FREE)_LIB_MEMORY macro as requested by Dmitry.
2008-05-22 09:38:21 +00:00
asfernandes
ffe554acc1
Misc
2008-05-21 16:04:10 +00:00
asfernandes
d84c1c1d2f
Misc
2008-05-21 16:02:25 +00:00
asfernandes
725a100324
Correction - thanks to Claudio
2008-05-21 15:22:22 +00:00
robocop
83f77468a0
Misc.
2008-05-21 13:00:37 +00:00
robocop
66aab208b0
Simplification.
2008-05-21 12:52:29 +00:00
robocop
ff1d4c61cf
Misc.
2008-05-21 12:41:58 +00:00
asfernandes
900c4ff7d3
Misc
2008-05-20 00:58:14 +00:00
asfernandes
d52dc96278
1) Move the new Node classes to appropriate files
...
2) Creation of StmtNode
3) Conversion of IN AUTONOMOUS TRANSACTION to InAutonomousTransactionNode (inherited from StmtNode) - it makes this feature almost self-contained
Please do a boot build or at least run blr_table.
2008-05-19 13:47:48 +00:00
asfernandes
e469bd562a
Cleanup on the "proc_flag" logic: store it on the request and changes when necessary.
2008-05-17 16:51:07 +00:00
asfernandes
7072385162
Typo
2008-05-15 16:02:33 +00:00
asfernandes
6c7170463a
Follow the standard and do not allow binary strings with odd number of characters
2008-05-15 15:27:43 +00:00
hvlad
0d27b88752
Commented out never reduced rule.
2008-05-15 11:43:56 +00:00
alexpeshkoff
27a97e2a6a
1. Modified syntax of ALTER ROLE command according to Dmitry's request.
...
2. Avoid any use of predefined NT group name "Domain Admins".
3. Fixed DYN code generation for USER operations.
***** WARNING *****
After this commit all previous backups of 2.5 databases with turned on
admins mapping become unrestorable. ODS is not changed.
2008-05-14 11:24:45 +00:00
asfernandes
7d34ead84e
1) Allow to reference others fields in the expression of ALTER...COMPUTED
...
2) Documentation
2008-05-11 20:05:12 +00:00
robocop
e44a99f339
Style and minor cleanup.
2008-05-10 03:44:57 +00:00
asfernandes
90b3b08ca0
Fixed the problematic assert
2008-05-06 15:20:18 +00:00
asfernandes
ac1cfe49a8
Remove a lot of warnings compiling parse.cpp with GCC 4.2.3
2008-05-01 16:12:16 +00:00
hvlad
02f2cef2db
Update DSQL_pretty to print nod_src_info contents even more correctly :) Noted by Adriano. Also make DSQL_pretty to not loop endlessly on nod_return.
2008-05-01 07:26:53 +00:00
hvlad
a1b08862f0
Corrected fix for bug CORE-1875. Noted by Adriano.
2008-05-01 07:22:11 +00:00
hvlad
62b5c645e5
Fixed bug CORE-1875 : Error on script with current_date
2008-04-30 20:04:18 +00:00
hvlad
7667d6e88f
Update DSQL_pretty to print nod_src_info contents correctly
2008-04-30 20:03:40 +00:00
dimitr
6fbb76c115
Fixed the crash reported privately by Bill Oliver.
2008-04-30 17:45:46 +00:00
hvlad
6ee4242552
Fixed bug CORE-1841 : If some VIEW used derived tables and long table names\aliases, It is possible to overflow RDB$VIEW_RELATIONS.RDB$CONTEXT_NAME.
...
Attention : ODS changed !
2008-04-29 16:39:17 +00:00
robocop
83d3ddd6cb
Replace custom code by helper class ThreadStatusGuard.
2008-04-26 10:29:52 +00:00
asfernandes
d75951e8e5
Misc
2008-04-18 01:37:44 +00:00
hvlad
48f8d0ff80
Correct my mistake
2008-04-17 10:47:31 +00:00
asfernandes
28d5b99afc
Misc
2008-04-16 16:02:01 +00:00
asfernandes
a7a7e18220
Fixed the bug reported by Claudio - crash when getting plan of DDL requests
2008-04-16 15:28:16 +00:00
hvlad
23dad7416f
Generate old blr codes (blr_exec_sql or blr_exec_into) if given EXEC STMT statement is compatible with old syntax. Per Adriano request.
2008-04-16 13:08:51 +00:00
robocop
4580126101
Do not use flags for values that are exclusive (can't be combined).
2008-04-16 10:38:08 +00:00
robocop
6f31045e33
Misc.
2008-04-16 09:25:36 +00:00
hvlad
a8a0a39248
Fixed CORE-1837 : Procedure text is stored truncated in system tables if any variable have default value
2008-04-15 19:45:19 +00:00
asfernandes
e4db82781f
Corrections
2008-04-15 15:31:21 +00:00
asfernandes
882e71fa81
Put nod_auto_trans in DSQL_pretty - noted by Claudio
2008-04-15 15:19:20 +00:00
asfernandes
77e97a47c0
Feature requests CORE-1737 and CORE-1803:
...
1) ALTER CHARACTER SET <charset> SET DEFAULT COLLATION <collation>
2) CREATE DATABASE ... [ DEFAULT CHARACTER SET <charset> [ COLLATION <collation> ] ]
2008-04-15 02:18:38 +00:00
asfernandes
79f8d2ceef
Misc
2008-04-15 00:57:19 +00:00
asfernandes
f66f7b28f5
1) Fix another possible invalid memory access in parse.y and the memcpy problem reported by valgrind
...
2) Misc
2008-04-14 15:22:52 +00:00
robocop
caa5f285c4
Minor cleanup.
2008-04-14 14:26:44 +00:00
asfernandes
e97cccd79d
Hope this fix a problem detected by valgrind
2008-04-14 13:35:15 +00:00
robocop
73093a8889
Mark dead code.
2008-04-14 13:01:54 +00:00
robocop
d54a9f7ef6
- Let BIN_AND, BIN_OR and BIN_XOR take two params as minimum.
...
- Implement BIN_NOT.
2008-04-14 11:09:16 +00:00
robocop
876cb8c11c
Better fix for the "unnamed field" bug. Thanks to Adriano for discovering a case that shouldn't be matched.
2008-04-14 07:05:49 +00:00
asfernandes
0ca6d7c20f
Use the collation defined in RDB$DEFAULT_COLLATE_NAME in strings constants
2008-04-12 22:26:24 +00:00
hvlad
f0899a7256
Make INTO clause of new EXECUTE STATEMENT consistent with other statements - move it at last position. By agreement in fb-devel.
2008-04-12 21:12:29 +00:00
asfernandes
80baf91394
Small cleanup
2008-04-12 16:07:45 +00:00
robocop
4de9c4050b
Use array notation.
2008-04-12 11:54:42 +00:00
robocop
64ea67ddf6
The "unnamed field" bug strikes again. :-(
2008-04-11 03:45:42 +00:00
asfernandes
6e59d736df
1) Fix Linux build
...
2) Misc
2008-04-11 01:38:50 +00:00
asfernandes
0e8febd6e3
Misc
2008-04-10 02:35:30 +00:00
hvlad
fe3f8c184b
New EXECUTE STATEMENT with support of external data source implementation
2008-04-09 20:18:47 +00:00
asfernandes
9037d1908a
Hope this fix one "problem" detected by Valgrind
2008-04-09 20:01:41 +00:00
robocop
cd9ede5768
Delete obsolete comment, fix indentation and style.
2008-04-09 13:47:15 +00:00
robocop
7c4114a7d6
It's harder to fix the assertion than to verify the code.
2008-04-08 06:26:34 +00:00
asfernandes
017e3a9cd0
Misc
2008-04-06 15:02:35 +00:00
asfernandes
29fbfbb8ff
Misc
2008-04-06 14:45:51 +00:00
robocop
752e3f1d43
Totally misc.
2008-04-06 08:07:00 +00:00
dimitr
4c9045523f
Removed the wrong assert. Adriano, please make sure the rest of the logic is ready for a zero field_string.
...
Test case: CREATE VIEW vt (id) AS SELECT id, 5 FROM t;
2008-04-04 18:26:38 +00:00
dimitr
1dcf8baa39
Put an extra check. Does anyone think that the condition should be "length > 0" instead?
2008-04-04 16:59:01 +00:00
dimitr
29229a10a6
Simplify the optional default value parsing and processing. This also fixes CORE-1512.
2008-04-04 16:53:29 +00:00
asfernandes
14c3e3f49d
Misc
2008-04-04 10:48:47 +00:00
dimitr
580544fbd7
More changes targeted to a better error diagnostics.
2008-04-04 10:01:06 +00:00
asfernandes
bc3a7f965d
Comment the new assertions as it's being false when using parameters in isql (UPDATE UserGroup SET ACL = ?) - to be reviewed by Claudio
2008-04-04 00:51:50 +00:00
robocop
ee46acd6bc
Misc.
2008-04-03 13:17:32 +00:00
dimitr
08c5783ab2
Misc.
2008-04-03 11:02:11 +00:00
hvlad
2b7f14dc69
Fixed CORE-1817 : The RelaxedAliasChecking parameter has no effect concerning RDB$DB_KEY
2008-04-02 14:27:17 +00:00
dimitr
e0feb6e228
Misc.
2008-04-01 12:56:30 +00:00
dimitr
30f7cce178
Fixed CORE-1811. A solution is to move the validation code from GEN to PASS1 in order to catch bad things earlier. This differs from the SAS solution, but hopefully it's more generic.
2008-04-01 06:11:29 +00:00
robocop
49ad645051
A half-backed solution to the const conflict problem. I hope the cure is at least slightly better than the disease.
2008-03-30 09:44:02 +00:00
