firebird/firebird-mirror
firebird/firebird-mirror
8
0
Fork 1
mirror of https://github.com/FirebirdSQL/firebird.git synced 2025-01-24 20:43:04 +01:00
Code Issues
24,429 Commits 55 Branches 76 Tags 281 MiB
fc6c274dcb
Commit Graph

295 Commits

Author SHA1 Message Date
robocop
3c361f66ba Simplify array bounds printing for canonic case. 2005-05-12 05:32:25 +00:00
robocop
3fd1859bd1 Workaround for SF Bug #450404. (Isql can't guess what the user intended.) 2005-05-02 07:11:39 +00:00
robocop
3f68b85b89 Another fix for the -b (Bail On Error) option when SQL commands are issued and no db connection exists yet. 
Apply Miroslav Penchev's patch for bug with -Q always returning 1 to the operating system, discovered by Ivan Prenosil.
 2005-04-28 06:26:24 +00:00
robocop
b2010a42e4 Fix indentation. 2005-04-25 05:23:57 +00:00
robocop
26c5ac04b0 This is my first attempt in four years to fix the nonsense code I wrote for grants extraction in FB1. 2005-04-04 08:33:43 +00:00
robocop
3379bed424 Isql shouldn't try to connect twice when extracting metadata, since the second attempt may produce a confusing message (the db name has been made null at this time). 2005-04-04 08:31:11 +00:00
robocop
4fbf25e341 Fix chaotic output. 2005-04-03 06:58:40 +00:00
robocop
7acd0a6d39 - Temporary fix for Pavel's firebird-Field-test-1173948. 
- Some little tweaks.
 2005-04-02 07:07:07 +00:00
robocop
f800fd59a7 I find hard to work with functions that span 800 or more lines. Therefore, I modularized process_statement. I took the opportunity to get rid of some local variables and fix performance info printing. 2005-04-02 03:51:43 +00:00
robocop
c5c02ed2e9 1.- Replacing raw call to gds__msg_format by ISQL_msg_get; the routine was there for years and almost unused. 
2.- UDFs are still created by sys_flag being NULL, so show_functions() should acknowledge that fact.
3.- Implement naive code to show an approximate script-related line number when a failure happens. (Unlike my private FB1's isql, it doesn't rely on strings subject to localization.)
4.- With SET PLANONLY ON, PLAN was activated, but with SET PLAN OFF, PLANONLY wasn't deactivated.
5.- Include isc_info_sql_stmt_get_segment among statements that are like SELECT.
6.- Solve a bad interaction between PLANONLY and SQLDA_DISPLAY, where the first being activated didn't allow to see the output XSQLDA.
7.- More error detection.
 2005-03-31 07:50:32 +00:00
robocop
5672f269e0 More WAL deletion. 2005-03-26 05:50:16 +00:00
robocop
29690221e1 1.- Some small buffers with predefined lengths don't need to be allocated dynamically. 
2.- ISQL_get_index_segments shouldn't overflow in extreme cases. Better print an indication that the extraction wasn't completed (ellipsis).
3.- Fix bug with EXTRACT_list table that was printing ); if it didn't find the required table. This in turn caused bugs in other functions.
4.- STDERROUT is used in all places with second argument set to true. Simplify it.
5.- Delete the code previously commented for WAL.
6.- Fix add_row and copy_table. These features were requested to be made available in release mode at v1 time by Paul Beach. They should now be able to cope with quoted identifiers, too.
7.- Complement usage of readNextInputLine when called directly to avoid reading garbage or causing memory errors.
8.- Fix several strings that should have been declared with MAXPATHLEN since the first moment.
9.- Misc bug fixes and B.O. closed.
 2005-03-26 05:33:55 +00:00
aafemt
ad88d1e805 Fix for Field-test item #1168910 2005-03-23 10:10:38 +00:00
skidder
56186e7f4d Calling clear_history like that breaks the builds. But even when build is fixed, call like that causes SIGSEGV due to editline history not being initalized when ISQL is used in non-interactive mode. Since clear_history doesn't free all the editline memory there is no big point in using it here anyways... 2005-03-09 06:53:03 +00:00
robocop
39c62a936d Totally misc. 2005-03-04 09:21:12 +00:00
robocop
ea866740f1 1.- Stop possible crash with long terminators. Pending other checks for the future. 
2.- Complete Damyan Ivanov's patch to allow BAIL detect really most error conditions.
3.- Create two functions to handle part of the bulky processing of isql's built-in commands.
4.- Make SET SQLDA_DISPLAY work in release versions and derive functionality to two new functions.
5.- Change Borland's moronic usage of a FIFO implemented in a linked list to handle the needs of a LIFO, simplying code and avoiding the associated logic pain.
6.- Avoid several SQL> prompts when using the INPUT command interactively.
7.- Free several resources on exit. Stop some additional memory leaks.
8.- Signal we are processing the INPUT command only when the file can be opened.
9.- Put the cursor declaration inside the code protected for scrollable cursors, in case it's needed there, since isql doesn't do positioned updates.

Remember to report random behavior, crashes, segmentation faults, core dumps and BSOD's.
 2005-03-04 09:17:34 +00:00
robocop
4be87294fa sqldaid and sqldabc are unused crap borrowed from IBM 15 years ago. 
Don't show them as they contain garbage.
 2005-02-07 09:00:33 +00:00
aafemt
d455bd79e4 LF already have been killed in readNextInputLine() 2005-01-26 10:37:53 +00:00
robocop
1361f698e1 Show system UDF's. According to Ann, she seems to remember that 
"there hasn't been a missing RDB$SYSTEM_FLAG since V2 except
objects created with direct system table inserts."
but if there are problems, I will have to do two loops.
 2005-01-04 05:42:26 +00:00
robocop
4012106884 Misc. 2004-12-25 09:44:03 +00:00
robocop
d65307b497 Style. 2004-12-24 08:52:39 +00:00
aafemt
1bb898274b Fix extra EOLN in interactive mode without editline 2004-12-23 10:15:49 +00:00
robocop
ba7f94f470 Misc. 2004-12-17 05:57:04 +00:00
aafemt
59f854c331 Fix for AV on EOF in interactive mode 2004-12-16 12:45:30 +00:00
aafemt
52aaaacfad Parser must parse, not input routine 2004-12-16 10:23:58 +00:00
aafemt
491cfb9abd Redundant comment 2004-12-16 10:13:51 +00:00
robocop
bd491bec02 Restore output if copy_table fails. 2004-12-12 02:01:52 +00:00
alexpeshkoff
387e678cca applied Clumplet* classes to dpb where possible 2004-12-09 19:19:47 +00:00
robocop
0dd1aced53 Misc. 2004-12-09 02:50:47 +00:00
skidder
aa80ac9481 Fix POSIX build after Claudio cleanup 2004-12-09 01:53:31 +00:00
robocop
001c8257a2 1.- Get rid of the std::string from the STL. 
2.- Add a couple of missing deallocations.
 2004-12-07 00:38:03 +00:00
robocop
308bdd3de1 Misc. 2004-12-07 00:33:16 +00:00
robocop
467277c241 Misc and solve a couple of missing deallocations. 2004-12-04 08:30:43 +00:00
robocop
9834b16376 Close the blob before returning an error. 2004-12-03 07:23:22 +00:00
robocop
7f0624da56 Misc. 2004-12-03 07:22:49 +00:00
robocop
4076ff0a11 First attempt to fix the double charset reporting bug that our dear Blas left in isql more than half a year ago. 2004-12-01 08:25:25 +00:00
robocop
af6a16107a Misc. 2004-11-30 06:18:39 +00:00
robocop
71989bd496 Don't show system functions. 2004-11-30 06:08:56 +00:00
skidder
51a992b959 Do not include system functions in database metadata script generated by ISQL 2004-11-30 03:22:50 +00:00
robocop
f8569104d6 Apply Adriano change with the following explanation: 
Fix a bug that occur when a BLOB column is added after the start of the DML transaction.
 2004-11-28 08:36:22 +00:00
robocop
e4ae004ca9 Completed (I hope) Damyan Ivanov's patch that didn't work with insertions, updates and deletions. 2004-11-28 07:05:42 +00:00
robocop
bb170bd3b6 isc_interpret is fb_interpret again. 
Please do a full rebuild.
 2004-11-28 01:03:05 +00:00
robocop
f6ec71ded5 Allow the -m2 option to work. 2004-11-24 09:04:06 +00:00
robocop
6f376126bc Applying Damyan Ivanov's isql patch. 
Document it in the interactive help isql -?
Document also the m2 option (merge diagnostics).
 2004-11-24 08:58:11 +00:00
robocop
c4cbb25f92 Misc. 2004-11-23 11:03:48 +00:00
robocop
cdeae35b31 Allow basic leaks reporting, fix a couple of leaks and delete obsolete comment. 2004-11-22 08:00:49 +00:00
hvlad
4fcd43a3d0 Allow isql to show large exception messages 2004-11-17 12:20:49 +00:00
robocop
628b088d2c Treat string literals and string constants with more respect. 2004-11-10 04:26:45 +00:00
robocop
5a33aeef91 Misc: extra semicolons do not help. :-) 2004-11-07 10:38:13 +00:00
robocop
1eb6693d0f When the XSQLDA is reallocated, set the version again (from my uncommitted FB1 fixes). 2004-11-07 10:20:27 +00:00
skidder
3e26513b38 fb_interpret->isc_interpet, deprecate isc_interpete, clean interface a little bit 2004-10-25 03:53:03 +00:00
robocop
31ba754981 After talking to Ann, decided to disable several items: 
- obsolete items like WAL and JOURNAL (cleaned in the past)
- crud from attempts never finished like the shared cache manager for Classic
- DSQL nodes that aren't used. This allowed freeing some keywords.
The functionality was disabled by commenting the code. No code has been deleted.
 2004-10-03 04:49:04 +00:00
robocop
3c8612ad7a Solve assertion in latest MSVC regarding isspace() with two helper functions. This is a mere reorganization of Adriano's fix. 2004-09-29 03:44:36 +00:00
skidder
02a0915156 Teach engine to work with larger record numbers - 64-bit internally, 40-bit externally 2004-09-28 06:28:38 +00:00
asfernandes
133f57e586 Fix a bug with international characters in ISQL causing assertions in VS2003 2004-09-26 02:57:40 +00:00
robocop
840bf14b36 If we are using namespace fb_utils, it doesn't make sense to prefix functions in it with fb_ again. Mechanical replacement made one by one (no bulk automatic changes). 2004-09-26 01:49:52 +00:00
robocop
e6cb17cac6 Vulnerability reported by Daniel Urban. 
First step: reorganize code.
Please do a full rebuild after retrieving those changes.
 2004-09-22 01:59:39 +00:00
robocop
f0d309811f Corrections 2004-09-22 01:55:37 +00:00
dimitr
74a845706b Minor fixes. 2004-09-05 15:00:51 +00:00
robocop
1c7aa47ec1 Showing role's description is dependent on the ODS 2004-08-31 06:26:27 +00:00
robocop
5ffd45799e When a role hasn't been granted, tell that. Do not hide the role (wasted two minutes to discover it wasn't gbak problem). Also, show the role's description. 2004-08-30 10:10:14 +00:00
robocop
84a00693d9 Misc 2004-08-30 10:07:49 +00:00
robocop
3236e206c8 Add in the help the mention of SET HEADING that was introduced time ago. 2004-08-27 08:34:41 +00:00
robocop
5eb042a638 Style 2004-08-27 05:13:47 +00:00
robocop
e3b269d2a4 Show ODS as part of SHOW DATABASE command. 2004-08-27 05:03:13 +00:00
robocop
41a21aa306 Support for new UDF mechanism 2004-08-27 05:01:56 +00:00
robocop
be2f4fe195 Style and comment useless code 2004-08-27 05:00:31 +00:00
aafemt
5dafdcb461 Make prompt visible in MSYS 2004-08-26 11:10:28 +00:00
aafemt
59f08d2a29 Rework statement pre-parsing. Now it doesn't swallow tabs 2004-08-26 10:28:57 +00:00
aafemt
e9403dd1b8 Use automatic buffers instead of dynamic 2004-08-25 11:43:09 +00:00
robocop
b60c0e4cab Misc: format 2004-08-21 09:29:46 +00:00
aafemt
cdb105b26e Let isql return error code on script errors 2004-08-19 10:26:09 +00:00
brodsom
da46a55b16 -Correction (Found by Claudio) 2004-07-21 10:34:27 +00:00
robocop
949830d0c6 1.- const correctness 
2.- style
3.- Try to fix the mess caused by different data types used to represent bifields of SCL_ constants defined in scl.h,
first round. No circular dependencies found through MSVC. Still pending dyn* and grant.epp files.
 2004-06-29 04:37:59 +00:00
brodsom
e8a210e39d -C++ struct declaration style. 2004-06-08 18:27:59 +00:00
robocop
c77040ff97 Style and const 2004-06-06 05:25:32 +00:00
robocop
1332d98618 Literal strings should be treated as const char* 2004-06-05 09:37:18 +00:00
robocop
3c56e6acfb Function ADD should not mangle date inputs 2004-05-31 02:35:58 +00:00
robocop
7b51928503 Style 2004-05-29 04:55:23 +00:00
brodsom
e34284aecf -Join isql globals in one struct (and remove some macros) and put not globals in the corresponding source. 
-Use C++ struct declaration style.
 2004-05-24 17:16:02 +00:00
brodsom
dd5d8aba0a -Replace stuff macros with either common stuff inlines or class inline functions 2004-05-24 11:03:54 +00:00
robocop
441817bd82 1.- Misc changes 
2.- Style
3.- Recover dsc_ttype in dsc after Blas' cleanup as a synonym for dsc_sub_type in text types
 2004-05-21 06:16:17 +00:00
brodsom
a76ee0147d -Macro cleaning 2004-05-18 21:59:25 +00:00
brodsom
eedff9ba57 -Macro cleaning 
-Move isql_res.h to isql.rh
 2004-05-18 16:21:39 +00:00
brodsom
13f149d77b -Fix ISO C++ errors (gcc -pedantic switch) 2004-05-13 09:25:24 +00:00
brodsom
1ffe279896 -Avoid shadow warning 2004-05-12 19:39:17 +00:00
brodsom
473abc461b Replace macro with inline-comments (Claudio found gpre have some issues with the ifdefs) 2004-05-10 00:18:34 +00:00
robocop
802f244ec1 Misc changes 2004-05-09 05:48:33 +00:00
brodsom
bdab6a747b Replace define with const 2004-05-07 07:52:47 +00:00
brodsom
66a3ae7a1c Fix warnings 2004-05-04 02:53:36 +00:00
skidder
43cb0d1ce4 Y-Valve handle translation layer 2004-05-02 23:06:37 +00:00
brodsom
a549091c94 - Split sqlda.h to avoid duplicated definitions between ibase.h and sqlda.h 
- Replace define for constants
- Remove contants.h where not used.
 2004-04-30 22:47:16 +00:00
brodsom
2c0ab256cf Removing duplicated definitions between 
ibase.h and blob_filter.h
ibase.h and constants.h
 2004-04-29 17:48:39 +00:00
brodsom
0daa189563 Removing ib_stdio.h 2004-04-28 22:36:29 +00:00
brodsom
9d24d7d9e3 -Fix #910430 
-Clean some #define
-Use parametrized language (pointed by Claudio)
 2004-04-26 07:54:22 +00:00
skidder
fa3f0c3b0a Return ISQL to buildable state after Blas' cleanup 2004-04-24 21:43:35 +00:00
brodsom
d077c22bd8 -Remove unneeded headers 2004-04-24 14:38:27 +00:00
brodsom
7cecfdcb7e -Fix bug #223126 (Misplaced collation when extracting metadadata with isql) 
-Fix bug #223513 (Ambiguity between tables and views)
-Fix bug #518349 (isql show mangles relationship)
-Remove V33 stuff
 2004-04-23 18:39:04 +00:00
brodsom
a379252b85 Use ifdef for obsolete code instead a loooong comment and avoid nested comment warnings 2004-04-21 00:18:48 +00:00
robocop
6d4c0ab908 Three changes to isql: 
Fix isql bug #910430.
Add SET HEADING ON/OFF option
Add -M2 command-line option to send output of statistics and plans to the same file than the rest of the output.
Those items do not appear when using HELP SET inside isql or with isql -? from the command line.
 2004-04-11 04:04:18 +00:00
robocop
59b235cea3 Small corrections 2004-04-10 00:25:22 +00:00
aafemt
34df983c67 Fix for procedure params extract. Global variables must die!! 2004-03-25 07:33:36 +00:00
skidder
c64f31b712 Fix some warnings from GCC/Linux build. Some of them were subtle errors 2004-03-12 07:00:52 +00:00
robocop
e6187cecd2 Cleanup 
Some bug fixes
Style
 2004-03-07 07:58:55 +00:00
robocop
2fa67d46bc Cleanup 
Reduce reinterpret and C casts
Fix isql so it can show all predefined blob types in readable form.
 2004-02-24 05:34:44 +00:00
alexpeshkoff
5314c1f8e1 Forward porting 2004-02-05 06:58:04 +00:00
robocop
663e3b16e7 Cleanup 2004-02-02 11:02:12 +00:00
skidder
08eee5ebaa Further AMD64 fixes. Given this fixes you may start playing with databases using isql_static. 2004-01-21 07:18:30 +00:00
robocop
de9c495e2b Misc change, style 2004-01-04 04:43:11 +00:00
fsg
e3ba8c5f42 Some changes to get it compiled under linux. 
Use const declarations for BLANK etc. in isql.h again.
FSG
 2004-01-03 14:12:45 +00:00
robocop
16cbc204df Cleanup 2003-12-31 05:36:12 +00:00
fsg
0a4f7ad482 oops, it wasn't intended to commit isql.epp, so roll it back 
FSG
 2003-12-27 18:50:01 +00:00
fsg
25a0180642 First changes to get it compiled under linux again. 
FSG
 2003-12-27 17:59:59 +00:00
robocop
ad0b5c4de3 General cleanup 2003-12-22 10:00:59 +00:00
robocop
84062732d8 More cleanup 2003-12-03 08:19:24 +00:00
brodsom
7844cc7cd4 Fix scope change that breaks posix build 2003-12-02 02:47:34 +00:00
robocop
775d776190 isql: more cleanup and restore the ability to have nested INPUT commands or run INPUT commands from the interactive session without quitting it. 2003-11-30 06:41:29 +00:00
robocop
9fafc348bf const correctness 
vars in scope
minimal interface cleanup
small bug fixes
 2003-11-28 06:48:34 +00:00
robocop
a94dbd85fd const correctness and other minor items 2003-11-18 07:58:35 +00:00
brodsom
453ff20031 -Removing some unneeded headers (WIN_NT) or explaining why are needed 2003-11-16 11:43:41 +00:00
brodsom
6e8e00c191 -Undo gds__vax_integer to isc_vax_integer and gds__event_* to isc_event_* changes 2003-11-16 01:44:51 +00:00
brodsom
c5253ae8a5 -Replace gds__ constants with isc_ contants 
-Replace codes.h with iberror.h (or remove)
-Move gds__vax_integer and gds__event_block* to alt.cpp and isc_ to gds.cpp
-Use ISC_QUAD internally
-Use isc_vax_integer internally
 2003-11-11 12:19:20 +00:00
robocop
9e7ca15236 Fix cleanup bug reported by Tomas Skoda 2003-11-10 09:47:28 +00:00
brodsom
4285bc623c Removing gdsold.h and gds.h 2003-11-08 16:40:17 +00:00
brodsom
500b806d7a Fix output format bug (win32) 2003-11-06 23:25:38 +00:00
robocop
35396625f5 const correctness 
function signatures
variables in local scope
BOOLEAN -> bool
TEXT[32] as SqlIdentifier for DYN
Stop random garbage in firebird.msg's bytes 8 to 11
some cleanup
 2003-11-05 09:02:33 +00:00
brodsom
f17bdcebc0 Fix for bug 781610 (-- comments in isql) 2003-11-04 03:49:22 +00:00
brodsom
1dec717bcd Correct bug in isql (Noticed by Arno) 2003-11-04 01:35:49 +00:00
robocop
9ead7a37b4 const correctness 
placed some variables in context
fixed some function signatures
closed a few possible buffer overruns
sorry to the platform maintainers, I can't verify what I did for non-Win32 builds
 2003-10-29 10:53:47 +00:00
brodsom
5a967335ad Fix bugs in isql (needed by fbtcs) 
-Detection of redirected input.
-Avoid \n\n\r output in echo mode on win32.
-Fix echo mode prompt output and make it work the same on win32 and linux.
 2003-10-23 23:06:39 +00:00
robocop
8182b6cba2 const correctness and other tasks 2003-10-16 08:51:06 +00:00
brodsom
8a7d7d294e extern cleaning 2003-10-02 19:20:55 +00:00
robocop
c931a674c2 Cleanup. 
Hopefully harmless
It should fix the issue introduced with constness in gds__interprete for current applications.
 2003-09-29 12:43:14 +00:00
robocop
484c6ec372 Cleanup, const correctness, variables in scope, etc. 
Having done my best to merge everyone else's changes, I hope the tree can be build with whatever other tools != MSVC6.
 2003-09-25 11:49:12 +00:00
arnobrinkman
65761dd0b3 Change wrong used constant (Suggested by Claudio V.) 2003-09-17 23:42:47 +00:00
aafemt
c1296d83e3 'struct' cleanup 2003-09-17 10:49:29 +00:00
arnobrinkman
822ee0552a Apply patch from Fred Polizo Jr. 
- Display correct OCTETS for varying length characters.
 2003-09-16 23:22:25 +00:00
brodsom
b88516b5c0 extern C cleaning 2003-09-10 17:48:24 +00:00
robocop
cdfac33f91 const correctness, bool, etc. 2003-09-09 11:03:37 +00:00
brodsom
382cd1c45e Code cleaning 2003-09-08 01:45:09 +00:00
brodsom
4d78970ab3 -Replacing BOOLEAN, FALSE and TRUE. 
-Code style cleaning
 2003-09-05 11:25:53 +00:00
brodsom
8624a7c209 -Use NULL instead 0 for null pointers 
-Remove unneeded casts
 2003-09-01 07:58:04 +00:00
brodsom
602c201989 -Remove NULL_PTR 
-Remove unneeded NULL casts
-Remove (void) function return cast
 2003-08-28 13:07:29 +00:00
brodsom
106b3a07f5 -Remove NULL_PTR macro 
-Remove unneeded casts
 2003-08-26 23:12:42 +00:00
brodsom
4a99ce0436 -Fix for MSVC6 format bug found in TCS DSQL_DOMAIN_12 and 13 2003-08-20 19:47:07 +00:00
skidder
5ffbcb4e62 Apply patch by Peter Jacobi to display OCTETS strings in hex correctly 2003-08-19 21:34:22 +00:00
brodsom
7009b693e0 -Fix a format warning (due to a coding error) 2003-08-09 23:38:27 +00:00
brodsom
4e4c8a921b Add an option to isql to set character set from command line, needed to connect with a command line specified database with non default charset. 2003-07-16 18:48:57 +00:00
brodsom
8feff51688 Remove depends (unused and unmaintained) 2003-07-08 23:38:30 +00:00
dimitr
30a1b1730b Fixed ISQL temp file bug. 2003-07-06 08:14:44 +00:00