firebird/firebird-qa
6
0
Fork 0
mirror of https://github.com/FirebirdSQL/firebird-qa.git synced 2025-01-22 13:33:07 +01:00
Code Issues Activity

Added/Updated tests\bugs\gh_8231_test.py: Resultset of cursor that executes using instance of selectable PreparedStatement must be stored in some variable in order to have ability close it EXPLICITLY, before PS will be freed. Otherwise access violation can raises when Python runs garbage collection.

Browse Source
This commit is contained in:
pavel-zotov 2025-01-18 15:07:04 +03:00
parent 4606cf9126
commit 1301cd17ff
1 changed files with 31 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
tests/bugs/gh_8231_test.py
View File

@ -13,12 +13,19 @@ NOTES:
request size limit exceeded request size limit exceeded
Checked on 5.0.2.1485-274af35 -- all ok. Checked on 5.0.2.1485-274af35 -- all ok.
[18.01.2025] pzotov
Resultset of cursor that executes using instance of selectable PreparedStatement must be stored
in some variable in order to have ability close it EXPLICITLY (before PS will be freed).
Otherwise access violation raises during Python GC and pytest hangs at final point (does not return control to OS).
This occurs at least for: Python 3.11.2 / pytest: 7.4.4 / firebird.driver: 1.10.6 / Firebird.Qa: 0.19.3
The reason of that was explained by Vlad, 26.10.24 17:42 ("oddities when use instances of selective statements").
Thanks to dimitr for the advice on implementing the test. Thanks to dimitr for the advice on implementing the test.
""" """
import pytest import pytest
from firebird.qa import * from firebird.qa import *
from firebird.driver import driver_config, connect from firebird.driver import driver_config, connect, DatabaseError
init_script = """ init_script = """
create table t1(fld varchar(10) character set win1252); create table t1(fld varchar(10) character set win1252);
@ -66,14 +73,31 @@ def test_1(act: Action, capsys):
for r in cur: for r in cur:
print(r[0],r[1]) print(r[0],r[1])
ps = cur.prepare(test_sql) ps, rs = None, None
try:
ps = cur.prepare(test_sql)
# Print explained plan with padding eash line by dots in order to see indentations: # Print explained plan with padding eash line by dots in order to see indentations:
print( '\n'.join([replace_leading(s) for s in ps.detailed_plan.split('\n')]) ) print( '\n'.join([replace_leading(s) for s in ps.detailed_plan.split('\n')]) )
# ::: NB ::: 'ps' returns data, i.e. this is SELECTABLE expression.
# We have to store result of cur.execute(<psInstance>) in order to
# close it explicitly.
# Otherwise AV can occur during Python garbage collection and this
# causes pytest to hang on its final point.
# Explained by hvlad, email 26.10.24 17:42
rs = cur.execute(ps)
for r in rs:
print(r[0])
except:
print(e.__str__())
print(e.gds_codes)
finally:
if rs:
rs.close() # <<< EXPLICITLY CLOSING CURSOR RESULTS
if ps:
ps.free()
# Print data:
for r in cur.execute(ps):
print(r[0])
con.rollback() con.rollback()
act.expected_stdout = f""" act.expected_stdout = f"""