6
0
mirror of https://github.com/FirebirdSQL/firebird-qa.git synced 2025-01-22 13:33:07 +01:00

Added/Updated tests\bugs\gh_8223_test.py: Resultset of cursor that executes using instance of selectable PreparedStatement must be stored in some variable in order to have ability close it EXPLICITLY, before PS will be freed. Otherwise access violation can raises when Python runs garbage collection.

This commit is contained in:
pavel-zotov 2025-01-18 15:04:36 +03:00
parent 7a4b162bf8
commit 4606cf9126

View File

@ -14,6 +14,13 @@ NOTES:
Because of that, testing version are limited only for 5.0.2. FB 6.x currently is NOT tested. Because of that, testing version are limited only for 5.0.2. FB 6.x currently is NOT tested.
3. Custom driver config objects are created here, one with SubQueryConversion = true and second with false. 3. Custom driver config objects are created here, one with SubQueryConversion = true and second with false.
[18.01.2025] pzotov
Resultset of cursor that executes using instance of selectable PreparedStatement must be stored
in some variable in order to have ability close it EXPLICITLY (before PS will be freed).
Otherwise access violation raises during Python GC and pytest hangs at final point (does not return control to OS).
This occurs at least for: Python 3.11.2 / pytest: 7.4.4 / firebird.driver: 1.10.6 / Firebird.Qa: 0.19.3
The reason of that was explained by Vlad, 26.10.24 17:42 ("oddities when use instances of selective statements").
Checked on 5.0.2.1483-0bf2de0 -- all ok. Checked on 5.0.2.1483-0bf2de0 -- all ok.
Thanks to dimitr for the advice on implementing the test. Thanks to dimitr for the advice on implementing the test.
""" """
@ -80,6 +87,7 @@ def test_1(act: Action, capsys):
""" """
with connect(db_cfg_name, user = act.db.user, password = act.db.password) as con: with connect(db_cfg_name, user = act.db.user, password = act.db.password) as con:
ps, rs = None, None
try: try:
cur = con.cursor() cur = con.cursor()
cur.execute("select g.rdb$config_name, g.rdb$config_value from rdb$database r left join rdb$config g on g.rdb$config_name = 'SubQueryConversion'") cur.execute("select g.rdb$config_name, g.rdb$config_value from rdb$database r left join rdb$config g on g.rdb$config_name = 'SubQueryConversion'")
@ -91,12 +99,24 @@ def test_1(act: Action, capsys):
# Print explained plan with padding eash line by dots in order to see indentations: # Print explained plan with padding eash line by dots in order to see indentations:
print( '\n'.join([replace_leading(s) for s in ps.detailed_plan.split('\n')]) ) print( '\n'.join([replace_leading(s) for s in ps.detailed_plan.split('\n')]) )
# Print data: # ::: NB ::: 'ps' returns data, i.e. this is SELECTABLE expression.
for r in cur.execute(ps): # We have to store result of cur.execute(<psInstance>) in order to
# close it explicitly.
# Otherwise AV can occur during Python garbage collection and this
# causes pytest to hang on its final point.
# Explained by hvlad, email 26.10.24 17:42
rs = cur.execute(ps)
for r in rs:
print(r[0], r[1], r[2]) print(r[0], r[1], r[2])
except DatabaseError as e: except DatabaseError as e:
print(e.__str__()) print(e.__str__())
print(e.gds_codes) print(e.gds_codes)
finally:
if rs:
rs.close() # <<< EXPLICITLY CLOSING CURSOR RESULTS
if ps:
ps.free()
act.expected_stdout = f""" act.expected_stdout = f"""
SubQueryConversion true SubQueryConversion true