firebird/firebird-qa
6
0
Fork 0
mirror of https://github.com/FirebirdSQL/firebird-qa.git synced 2025-01-22 13:33:07 +01:00
Code Issues Activity

Added/Updated tests\bugs\core_5845_test.py: change expected plan for one of provided queries because there was a bug fixed in intermediate snapshot 5.0.0.1204 with timestamp 12-sep-2023 08:00.

Browse Source
This commit is contained in:
pavel-zotov 2023-09-12 12:49:30 +03:00
parent 566e6fa091
commit a427e6f7bc
1 changed files with 33 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
tests/bugs/core_5845_test.py
View File

@ -9,11 +9,17 @@ JIRA: CORE-5845
FBTEST: bugs.core_5845
NOTES:
[12.09.2023] pzotov
Refactored: use firebird-driver ability to show plan (instead of call ISQL), removed hard-coded index names.
1. Refactored: use firebird-driver ability to show plan (instead of call ISQL), removed hard-coded index names.
Expected result is "accumulated" by traversing through dictionary items (see 'chk_qry_map') instead of be written beforehand.
Added several queries provided by dimitr, letter 12-sep-2023.
Checked on: 3.0.12.33707; 4.0.4.2986; 5.0.0.1204
2. ATTENTION: plan for query "select ... where t.id1 = 1 and t.x > 0 and t.id2 = 0" - has been changed in intermediate snapshot
5.0.0.1204 (timestamp: 20230912 08:00). One need to split expected results for FB 5.x+ and older versions.
See:
https://github.com/FirebirdSQL/firebird/commit/022f09287747dd05753bd11acd3b3fe4b0756f6e
https://github.com/FirebirdSQL/firebird/compare/252c5b2b2f88...784f7bd8a6f5
Checked on: 3.0.12.33707; 4.0.4.2986; 5.0.0.1204 (nightly build and intermediate snapshot of 12-sep-2023 08:00).
"""
import pytest
@ -37,10 +43,11 @@ init_sql = f"""
commit;
"""
chk_qry_map = {
chk_qry_map_fb4 = {
"select * from test t where t.id1=1 and t.x>0" : f"PLAN (T INDEX ({COMPOUND_IDX}))"
,"select * from test t where t.id1=1 and t.x>0 order by t.id1, t.id2, t.id3" : f"PLAN SORT (T INDEX ({COMPOUND_IDX}))"
,"select * from test t where t.id1=1 and t.x>0 order by t.id1+0, t.id2, t.id3" : f"PLAN SORT (T INDEX ({COMPOUND_IDX}))"
# following examples were provided by dimitr, 12-sep-2023:
,"select * from test t where t.id1 = 1 and t.x > 0 and t.id2 = 0" : f"PLAN (T INDEX ({COMPOUND_IDX}))"
,"select * from test t where t.id1 = 1 and t.x = 0" : f"PLAN (T INDEX ({COMPOUND_IDX}))"
@ -49,12 +56,33 @@ chk_qry_map = {
,"select * from test t where t.id1 = 1 and t.x = 0 and t.id2 = 0" : f"PLAN (T INDEX ({COMPOUND_IDX}))"
}
chk_qry_map_fb5 = {
"select * from test t where t.id1=1 and t.x>0" : f"PLAN (T INDEX ({COMPOUND_IDX}))"
,"select * from test t where t.id1=1 and t.x>0 order by t.id1, t.id2, t.id3" : f"PLAN SORT (T INDEX ({COMPOUND_IDX}))"
,"select * from test t where t.id1=1 and t.x>0 order by t.id1+0, t.id2, t.id3" : f"PLAN SORT (T INDEX ({COMPOUND_IDX}))"
# following examples were provided by dimitr, 12-sep-2023:
##########################################################
# ::: NB ::: Since 5.0.0.1204 (intermediate snapshot with timestamp 20230912 08:00) plan for following query
# "select ... where t.id1 = 1 and t.x > 0 and t.id2 = 0" -- has been changed to: PLAN (T INDEX (TEST_PK_ID1_ID2_ID3))
##########################################################
,"select * from test t where t.id1 = 1 and t.x > 0 and t.id2 = 0" : f"PLAN (T INDEX ({P_KEY_IDX}))"
,"select * from test t where t.id1 = 1 and t.x = 0" : f"PLAN (T INDEX ({COMPOUND_IDX}))"
,"select * from test t where t.id1 = 1 and t.id2 = 2" : f"PLAN (T INDEX ({P_KEY_IDX}))"
,"select * from test t where t.id1 = 1 and t.id2 = 2 and t.id3 = 3" : f"PLAN (T INDEX ({P_KEY_IDX}))"
,"select * from test t where t.id1 = 1 and t.x = 0 and t.id2 = 0" : f"PLAN (T INDEX ({COMPOUND_IDX}))"
}
db = db_factory(init = init_sql)
act = python_act('db')
@pytest.mark.version('>=3.0.4')
def test_1(act: Action, capsys):
if act.is_version('<5'):
chk_qry_map = chk_qry_map_fb4
else:
chk_qry_map = chk_qry_map_fb5
expected_plans_lst = [ '\n'.join((k,v)) for k,v in chk_qry_map.items() ]
with act.db.connect() as con: