Added/Updated tests\functional\domain\create\test_19.py: Removed SHOW command for check result because its output often changes. It is enough for this test to obtain similar data from RDB tables. Created view and stored function to obtain type name by rdb$fields.rdb$field_type and .rdb$field_sub_type.

tests/functional/domain/create/test_19.py

@@ -3,25 +3,109 @@
 """
 ID:          domain.create-19
 FBTEST:      functional.domain.create.19
-TITLE:       CREATE DOMAIN - VARCHAR - ARRAY
+TITLE:       CREATE DOMAIN - VARCHAR ARRAY
 DESCRIPTION: Array domain creation based on VARCHAR datatype
+NOTES:
+    [06.10.2023] pzotov
+    1. Removed SHOW command for check result because its output often changes.
+       It is enough for this test to obtain similar data from RDB tables.
+       Created view and stored function to obtain type name by rdb$fields.rdb$field_type and .rdb$field_sub_type.
+    2. Made example more complex: create domain with charset differ than default one for DB, and collate differ than default for domain.
 """
 
 import pytest
 from firebird.qa import *
 
-db = db_factory()
+db = db_factory(charset = 'win1250')
 
-test_script = """CREATE DOMAIN test VARCHAR(32765)[40000];
-SHOW DOMAIN test;"""
+DM_SIZE = 32765
+
+test_script = f"""
+    set bail on;
+    set list on;
+    alter character set win1252 set default collation pxw_swedfin;
+
+    set term ^;
+    create or alter function fn_get_type_name(a_type smallint, a_subtype smallint) returns varchar(2048) as
+        declare ftype varchar(2048);
+    begin
+        ftype = 
+            decode( a_type
+                    ,  7, decode(coalesce(a_subtype,0),  0, 'smallint',             1, 'numeric', 'unknown') -- 1 => small numerics [-327.68..327.67] (i.e. with mantissa that can be fit in -32768 ... 32767)
+                    ,  8, decode(coalesce(a_subtype,0),  0, 'integer',              1, 'numeric', 2, 'decimal', 'unknown') -- 1: for numeric with mantissa >= 32768 and up to 9 digits, 2: for decimals up to 9 digits
+                    , 10, 'float'
+                    , 12, 'date'
+                    , 13, 'time without time zone'
+                    , 14, decode(coalesce(a_subtype,0),  0, 'char',                 1, 'binary', 'unknown')
+                    , 16, decode(coalesce(a_subtype,0),  0, 'bigint',               1, 'numeric', 2, 'decimal', 'unknown')
+                    , 23, 'boolean'
+                    , 24, 'decfloat(16)'
+                    , 25, 'decfloat(34)'
+                    , 26, 'int128'
+                    , 27, 'double precision' -- also for numeric and decimal, both with size >= 10, if sql_dialect = 1
+                    , 28, 'time with time zone'
+                    , 29, 'timestamp with time zone'
+                    , 35, 'timestamp without time zone'
+                    , 37, decode(coalesce(a_subtype,0),  0, 'varchar',              1, 'varbinary', 'unknown')
+                    ,261, decode(coalesce(a_subtype,0),  0, 'blob sub_type binary', 1, 'blob sub_type text', 'unknown')
+                  );
+        if (ftype = 'unknown') then
+            ftype = ftype || '__type_'  || coalesce(a_type, '[null]') || '__subtype_' || coalesce(a_subtype, '[null]');
+        return ftype;
+    end
+    ^
+    set term ;^
+    commit;
+
+    create view v_domain_info as
+    select
+        f.rdb$field_name as dm_name
+        ,upper(fn_get_type_name(f.rdb$field_type, f.rdb$field_sub_type)) as dm_type
+        ,f.rdb$field_length as dm_size
+        ,f.rdb$field_scale as dm_scale
+        ,d.rdb$lower_bound as dim_start
+        ,d.rdb$upper_bound as dim_finish
+        ,f.rdb$character_length as dm_char_len
+        --,f.rdb$character_set_id as dm_cset_id
+        --,f.rdb$collation_id as dm_coll_id
+        ,f.rdb$default_source as dm_default
+        ,f.rdb$null_flag as dm_not_null
+        ,f.rdb$validation_source as dm_check_expr
+        ,c.rdb$character_set_name as dm_cset_name
+        --,c.rdb$default_collate_name as dm_default_coll_name
+        --,k.rdb$base_collation_name
+        ,k.rdb$collation_name as dm_coll_name
+    from rdb$fields f
+    left join rdb$character_sets c on f.rdb$character_set_id = c.rdb$character_set_id
+    left join rdb$collations k on c.rdb$character_set_id = k.rdb$character_set_id and f.rdb$collation_id = k.rdb$collation_id
+    left join rdb$field_dimensions d on f.rdb$field_name = d.rdb$field_name
+    where f.rdb$field_name = upper('dm_test')
+    ;
+    commit;
+    create domain dm_test VARCHAR({DM_SIZE})[40000] character set win1252 collate win_ptbr;
+    commit;
+    select v.* from v_domain_info v;
+"""
 
 act = isql_act('db', test_script)
 
-expected_stdout = """TEST                            ARRAY OF [40000]
-VARCHAR(32765) Nullable"""
+expected_stdout = f"""
+    DM_NAME                         DM_TEST
+    DM_TYPE                         VARCHAR
+    DM_SIZE                         32765
+    DM_SCALE                        0
+    DIM_START                       1
+    DIM_FINISH                      40000
+    DM_CHAR_LEN                     32765
+    DM_DEFAULT                      <null>
+    DM_NOT_NULL                     <null>
+    DM_CHECK_EXPR                   <null>
+    DM_CSET_NAME                    WIN1252
+    DM_COLL_NAME                    WIN_PTBR
+"""
 
 @pytest.mark.version('>=3')
 def test_1(act: Action):
     act.expected_stdout = expected_stdout
-    act.execute()
+    act.execute(combine_output = True)
     assert act.clean_stdout == act.clean_expected_stdout